Skip to content

fix typo #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2016
Merged

fix typo #90

merged 1 commit into from
Sep 27, 2016

Conversation

radekdoulik
Copy link
Member

  • we actually want the disposing to be set to true when called from
    IDisposing.Dispose method so that the resources are disposed
    (unlike when called from finalizer)
  • this fixes part of #44529

@dnfclas
Copy link

dnfclas commented Sep 27, 2016

Hi @radekdoulik, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@radekdoulik
fix typo
39ba303 
 - we actually want the disposing to be set to true when called from
   IDisposable.Dispose method so that the resources are disposed
   (unlike when called from finalizer)

 - this fixes part of #44529
@radekdoulik
Copy link
Member Author

corrected IDisposing.Dispose --> IDisposable.Dispose in the commit message

@jonpryor jonpryor merged commit f153b7a into dotnet:master Sep 27, 2016
jonpryor pushed a commit that referenced this pull request Sep 25, 2020
@jpobst
Bump to xamarin/xamarin-android-tools/master@f2af06f2 (#733)
ee50d89 
Changes: dotnet/android-tools@3974fc3...f2af06f

  * dotnet/android-tools@f2af06f: [Xamarin.Android.Tools.AndroidSdk] Fix a few nullability warnings (#97)
  * dotnet/android-tools@5718cd2: Fix sort ordering for ndk-bundle, add macOS support (#91)
  * dotnet/android-tools@8e63795: [Xamarin.Android.Tools.AndroidSdk] Add API-29, API-30 to KnownVersions (#89)
  * dotnet/android-tools@a6a23bb: [Xamarin.Android.Tools.AndroidSdk] Default SDK component versions (#93)
  * dotnet/android-tools@32a1e2c: [build] fail macOS build if tests fail (#94)
  * dotnet/android-tools@79a0141: Return a default for unknown API levels (#90)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radekdoulik @dnfclas @jonpryor