Skip to content
This repository was archived by the owner on Nov 16, 2019. It is now read-only.

Feature/support generics #6

Closed
wants to merge 12 commits into from
Closed

Feature/support generics #6

wants to merge 12 commits into from

Conversation

mrpmorris
Copy link
Contributor

@mrpmorris mrpmorris commented Oct 27, 2018

This pull request splits the MethodInfo caching used by DotNetDispatcher into two; one for calling static methods and one for calling instance methods.

Method identifiers on static methods must be unique per assembly, whereas for instance methods they only need to be unique for the instance's class hierarchy.

Generics are now supported, but only when invoking instance methods and only if there are no open generics.

JSInvokable now no longer has a parameterless constructor so that the specifying of the method identifier is always explicit as per @SteveSandersonMS's suggestion on Twitter.

Addresses issues

@mrpmorris
Copy link
Contributor Author

@danroth27 @SteveSandersonMS This PR has been done for a while as per direction given to me by Steve, wondering if it has been forgotten?

@SteveSandersonMS
Copy link
Member

@mrpmorris Sorry for the slow response. It's on my backlog to review soon.

@mrpmorris
Copy link
Contributor Author

Thanks for the update @SteveSandersonMS - Don't mean to hassle, just want to make sure that if it doesn't get in it's because you didn't like it rather than because it got lost 👍

@aspnet-hello
Copy link

We're closing this item because this project has moved to another repo.

Please go to https://github.com/aspnet/Extensions/tree/master/src/JSInterop to see the latest JSInterop code base and to file issues.

We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.

@dotnet dotnet locked and limited conversation to collaborators Apr 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants