Code coverage support #2116
Code coverage support #2116
Conversation
test/run-tests.proj
Outdated
| @@ -10,7 +10,7 @@ | |||
| <Message Importance="High" Text="Running tests ..." /> | |||
| <MSBuild Targets="VSTest" | |||
| Projects="@(Project)" | |||
| Properties="VSTestNoBuild=true" /> | |||
| Properties="VSTestNoBuild=true;Coverage=true;CopyLocalLockFileAssemblies=true" /> | |||
There was a problem hiding this comment.
CopyLocalLockFileAssemblies=true
Is this not a duplicate of the value in Directory.Build.targets set whenever Coverage is true?
test/run-tests.proj
Outdated
| @@ -10,7 +10,7 @@ | |||
| <Message Importance="High" Text="Running tests ..." /> | |||
| <MSBuild Targets="VSTest" | |||
| Projects="@(Project)" | |||
| Properties="VSTestNoBuild=true" /> | |||
| Properties="VSTestNoBuild=true;Coverage=true;" /> | |||
There was a problem hiding this comment.
There should be a way to shut this off locally, if devs don't want it. #Resolved
There was a problem hiding this comment.
Correct, that option needs to be added to the run tool and removed here. #Resolved
test/Directory.Build.targets
Outdated
|
|
||
| <PropertyGroup Condition="'$(Coverage)' == 'true' and '$(Configuration)'=='Release' and '$(OS)' == 'Windows_NT' and '$(TargetArchitecture)' == 'x64'"> | ||
| <CollectCoverage>true</CollectCoverage> | ||
| <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies> |
There was a problem hiding this comment.
Why is this necessary? Does the coverage tool require it? If so, can you link to information on it?
Codecov Report
@@ Coverage Diff @@
## master #2116 +/- ##
=========================================
Coverage ? 26.31%
=========================================
Files ? 7
Lines ? 1592
Branches ? 0
=========================================
Hits ? 419
Misses ? 1173
Partials ? 0
Continue to review full report at Codecov.
|
ghost
locked as resolved and limited conversation to collaborators
This is a WIP PR that adds code coverage support. This change contains code that generates code coverage files. In the next iteration I will add code to upload code coverage files to CodeCov once I know builds pass and a way to disable code coverage if needed.