Add code coverage build def. #2166
Conversation
build/ci/phase-template.yml
Outdated
|
|
||
| - ${{ if eq(variables['codeCoverageBuild'], 'true') }}: | ||
| - phase: ${{ parameters.name }} | ||
| variables: |
There was a problem hiding this comment.
I think variables can be common across the two blocks
There was a problem hiding this comment.
We should confirm that the performance overhead of running code coverage alongside one of the current debug builds is substantial before breaking it out into its own leg. Performance testing is currently blocked while we wait for the next release of coverlet.
build/ci/phase-template.yml
Outdated
| @@ -6,7 +6,8 @@ parameters: | |||
| customMatrixes: '' | |||
|
|
|||
| phases: | |||
| - phase: ${{ parameters.name }} | |||
| - ${{ if ne(variables['codeCoverageBuild'], 'true') }}: | |||
| - phase: ${{ parameters.name }} | |||
| variables: | |||
There was a problem hiding this comment.
You would need to indent everything under these if blocks in this file if you go with the current structure of the phase blocks.
That is why the build is failing:
phase-template.yml (Line: 11, Col: 5, Idx: 199) - (Line: 11, Col: 5, Idx: 199): While parsing a block collection, did not find expected '-' indicator.
.vsts-dotnet-ci.yml
Outdated
| @@ -8,7 +8,7 @@ resources: | |||
| image: microsoft/dotnet-buildtools-prereqs:centos-7-b46d863-20180719033416 | |||
|
|
|||
| phases: | |||
| - ${{ if ne(variables['codeCoverageBuild'], 'true') }}: | |||
| ${{ if ne(variables['codeCoverageBuild'], 'true') }}: | |||
There was a problem hiding this comment.
the - are needed at the beginning of this ifs because phases expect objects to be declared. In yaml you specify an object with - the error you're getting I described it in another comment.
ghost
locked as resolved and limited conversation to collaborators
Adds a new CI leg just for code coverage. The reason for adding a new leg is not let code coverage process affect PR merge.