Skip to content

Fix DataFrame.LoadCsv can not load CSV with duplicate column names #6772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Fix DataFrame.LoadCsv can not load CSV with duplicate column names #6772

merged 3 commits into from
Aug 31, 2023

Conversation

asmirnov82
Copy link
Contributor

Fixes #6182

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #6772 (2c72e8c) into main (39235a7) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6772      +/-   ##
==========================================
+ Coverage   69.03%   69.06%   +0.02%     
==========================================
  Files        1237     1237              
  Lines      252700   252742      +42     
  Branches    26446    26449       +3     
==========================================
+ Hits       174449   174544      +95     
+ Misses      71308    71261      -47     
+ Partials     6943     6937       -6     
Flag Coverage Δ
Debug 69.06% <100.00%> (+0.02%) ⬆️
production 63.63% <100.00%> (+0.02%) ⬆️
test 88.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Microsoft.Data.Analysis/DataFrame.IO.cs 83.12% <100.00%> (+0.58%) ⬆️
...Microsoft.Data.Analysis.Tests/DataFrame.IOTests.cs 99.00% <100.00%> (+0.02%) ⬆️

... and 7 files with indirect coverage changes

@michaelgsharp
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@michaelgsharp michaelgsharp merged commit e3f53a4 into dotnet:main Aug 31, 2023
@asmirnov82 asmirnov82 deleted the 6182_load_csv_duplicate_columns branch August 31, 2023 06:05
@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame.LoadCsv can not load CSV with duplicate column names
3 participants