Update to M.E.AI 9.3.0-preview.1.25161.3 #7414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates various chat client implementations and chat template builders from using IList to IEnumerable for improved flexibility in handling message collections. It also adds a unique ResponseId in the pipeline chat client and standardizes parameter types across multiple client implementations.
- Changed parameter types in GetResponseAsync and GetStreamingResponseAsync methods.
- Updated BuildPrompt methods in chat template builders.
- Added a ResponseId property in the chat response update.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.ML.GenAI.Core/CausalLMPipelineChatClient.cs | Updated method signatures and added ResponseId generation. |
| src/Microsoft.ML.GenAI.LLaMA/Llama3CausalLMChatClient.cs | Updated method signatures; includes initialization of StopSequences. |
| src/Microsoft.ML.GenAI.Core/Utility/IChatTemplateBuilder.cs | Updated BuildPrompt parameter type to IEnumerable. |
| src/Microsoft.ML.GenAI.Phi/Phi3/Phi3CausalLMChatClient.cs | Updated method signatures for consistency with IEnumerable. |
| src/Microsoft.ML.GenAI.Phi/Phi3/Phi3ChatTemplateBuilder.cs | Updated BuildPrompt parameter type to IEnumerable. |
| src/Microsoft.ML.GenAI.LLaMA/Llama3_1ChatTemplateBuilder.cs | Updated BuildPrompt parameter type to IEnumerable. |
Comments suppressed due to low confidence (1)
src/Microsoft.ML.GenAI.LLaMA/Llama3CausalLMChatClient.cs:52
- Using [] to initialize StopSequences is not valid C# syntax. Replace it with a proper empty list initialization such as new List() or Array.Empty() depending on the expected type.
options.StopSequences ??= [];
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
ericstj
approved these changes
Mar 12, 2025
|
/ba-g all failures are covered by known issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.