Skip to content

Increase cancelling waiting time for AutoMLExperiment_return_current_best_trial_when_ct_is_canceled_with_trial_completed_Async #7424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

LittleLittleCloud
Copy link
Contributor

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.
    AutoMLExperiment_return_current_best_trial_when_ct_is_canceled_with_trial_completed_Async fails in CI #7418

@Copilot Copilot AI review requested due to automatic review settings March 17, 2025 21:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the timeout duration in a cancellation-related test for the AutoMLExperiment.

  • Updated the cancellation timing expectation in the test.
  • Adjusted the magic number used to assert the elapsed time after cancellation.
Comments suppressed due to low confidence (1)

test/Microsoft.ML.AutoML.Tests/AutoMLExperimentTests.cs:146

  • [nitpick] Consider replacing the magic number 5000 with a named constant or a computation based on _finishAfterNSeconds to improve code readability and maintainability.
stopWatch.ElapsedMilliseconds.Should().BeLessThanOrEqualTo(5000);

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.97%. Comparing base (adad40c) to head (4746272).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7424   +/-   ##
=======================================
  Coverage   68.97%   68.97%           
=======================================
  Files        1481     1481           
  Lines      273708   273708           
  Branches    28285    28285           
=======================================
+ Hits       188789   188801   +12     
+ Misses      77525    77513   -12     
  Partials     7394     7394           
Flag Coverage Δ
Debug 62.61% <100.00%> (+<0.01%) ⬆️
production 62.61% <ø> (+<0.01%) ⬆️
test ∅ <100.00%> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...Microsoft.ML.AutoML.Tests/AutoMLExperimentTests.cs 84.40% <100.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michaelgsharp michaelgsharp merged commit 1ccbbd4 into main Mar 24, 2025
25 checks passed
@michaelgsharp michaelgsharp deleted the LittleLittleCloud-patch-1 branch March 24, 2025 17:45
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants