Dependency version updates #7457

michaelgsharp · 2025-05-05T23:12:16Z

Update most dependency versions.

Copilot

Pull Request Overview

This PR updates dependency versions and deprecates several test methods by adding [Obsolete] attributes and related warning suppressions. The key changes include:

Marking diagnostic and test methods as obsolete to indicate deprecation.
Adding SuppressMessage attributes with pending justifications in one test file.
Updating a test to be skipped with an accompanying obsolete marker.

Reviewed Changes

Copilot reviewed 28 out of 38 changed files in this pull request and generated 3 comments.

File	Description
test/Microsoft.ML.CodeAnalyzer.Tests/Helpers/CSharpCodeFixVerifier`2.cs	Added [Obsolete] attributes to the Diagnostic() overloads and applied warning suppression around an internal test class.
test/Microsoft.ML.CodeAnalyzer.Tests/Code/TypeParamNameTest.cs	Added an [Obsolete] attribute on the test method.
test/Microsoft.ML.CodeAnalyzer.Tests/Code/RelaxTestNamingTest.cs	Introduced multiple SuppressMessage attributes with "" justifications.
Others	Similar [Obsolete] attributes were added across various test files to mark methods for future deprecation.

Files not reviewed (10)

docs/samples/Microsoft.ML.GenAI.Samples/Microsoft.ML.GenAI.Samples.csproj: Language not supported
docs/samples/Microsoft.ML.Samples/Microsoft.ML.Samples.csproj: Language not supported
eng/Versions.props: Language not supported
src/Microsoft.ML.AutoML.Interactive/Microsoft.ML.AutoML.Interactive.csproj: Language not supported
src/Microsoft.ML.AutoML/Microsoft.ML.AutoML.csproj: Language not supported
src/Microsoft.ML.GenAI.Core/Microsoft.ML.GenAI.Core.csproj: Language not supported
src/Microsoft.ML.GenAI.Mistral/Microsoft.ML.GenAI.Mistral.csproj: Language not supported
src/Microsoft.ML.GenAI.Phi/Microsoft.ML.GenAI.Phi.csproj: Language not supported
test/Microsoft.ML.GenAI.Core.Tests/Microsoft.ML.GenAI.Core.Tests.csproj: Language not supported
test/Microsoft.ML.GenAI.LLaMA.Tests/Microsoft.ML.GenAI.LLaMA.Tests.csproj: Language not supported

Copilot · 2025-05-05T23:13:17Z

test/Microsoft.ML.CodeAnalyzer.Tests/Helpers/CSharpCodeFixVerifier`2.cs

+        [System.Obsolete]
        public static DiagnosticResult Diagnostic()
                => CSharpCodeFixVerifier<TAnalyzer, TCodeFix, XUnitVerifier>.Diagnostic();

+        [System.Obsolete]
        public static DiagnosticResult Diagnostic(string diagnosticId)
            => CSharpCodeFixVerifier<TAnalyzer, TCodeFix, XUnitVerifier>.Diagnostic(diagnosticId);

+        [System.Obsolete]


Consider adding a descriptive message to the Obsolete attribute (e.g., Obsolete("Use Diagnostic() from ... instead")) to clearly communicate the intended replacement or removal plan.

Suggested change

[System.Obsolete]

public static DiagnosticResult Diagnostic()

=> CSharpCodeFixVerifier<TAnalyzer, TCodeFix, XUnitVerifier>.Diagnostic();

[System.Obsolete]

public static DiagnosticResult Diagnostic(string diagnosticId)

=> CSharpCodeFixVerifier<TAnalyzer, TCodeFix, XUnitVerifier>.Diagnostic(diagnosticId);

[System.Obsolete]

[System.Obsolete("Use CSharpCodeFixVerifier<TAnalyzer, TCodeFix, XUnitVerifier>.Diagnostic() instead.")]

public static DiagnosticResult Diagnostic()

=> CSharpCodeFixVerifier<TAnalyzer, TCodeFix, XUnitVerifier>.Diagnostic();

[System.Obsolete("Use CSharpCodeFixVerifier<TAnalyzer, TCodeFix, XUnitVerifier>.Diagnostic(string diagnosticId) instead.")]

public static DiagnosticResult Diagnostic(string diagnosticId)

=> CSharpCodeFixVerifier<TAnalyzer, TCodeFix, XUnitVerifier>.Diagnostic(diagnosticId);

[System.Obsolete("Use CSharpCodeFixVerifier<TAnalyzer, TCodeFix, XUnitVerifier>.Diagnostic(DiagnosticDescriptor descriptor) instead.")]

Copilot · 2025-05-05T23:13:18Z

test/Microsoft.ML.CodeAnalyzer.Tests/Code/RelaxTestNamingTest.cs

+        [SuppressMessage("MicrosoftCodeAnalysisCorrectness", "RS1041:Compiler extensions should be implemented in assemblies targeting netstandard2.0", Justification = "<Pending>")]
+        [SuppressMessage("MicrosoftCodeAnalysisCorrectness", "RS1038:Compiler extensions should be implemented in assemblies with compiler-provided references", Justification = "<Pending>")]
+        [SuppressMessage("MicrosoftCodeAnalysisCorrectness", "RS1036:Specify analyzer banned API enforcement setting", Justification = "<Pending>")]


Replace the placeholder '' in the Justification fields with a concrete description detailing why the suppression is necessary.

Suggested change

[SuppressMessage("MicrosoftCodeAnalysisCorrectness", "RS1041:Compiler extensions should be implemented in assemblies targeting netstandard2.0", Justification = "<Pending>")]

[SuppressMessage("MicrosoftCodeAnalysisCorrectness", "RS1038:Compiler extensions should be implemented in assemblies with compiler-provided references", Justification = "<Pending>")]

[SuppressMessage("MicrosoftCodeAnalysisCorrectness", "RS1036:Specify analyzer banned API enforcement setting", Justification = "<Pending>")]

[SuppressMessage("MicrosoftCodeAnalysisCorrectness", "RS1041:Compiler extensions should be implemented in assemblies targeting netstandard2.0", Justification = "This test is not targeting netstandard2.0 because it is designed for a specific testing scenario.")]

[SuppressMessage("MicrosoftCodeAnalysisCorrectness", "RS1038:Compiler extensions should be implemented in assemblies with compiler-provided references", Justification = "This test does not require compiler-provided references due to its isolated nature.")]

[SuppressMessage("MicrosoftCodeAnalysisCorrectness", "RS1036:Specify analyzer banned API enforcement setting", Justification = "The banned API enforcement setting is not relevant for this test.")]

Copilot · 2025-05-05T23:13:18Z

test/Microsoft.ML.CodeAnalyzer.Tests/Code/TypeParamNameTest.cs

@@ -14,6 +15,7 @@ namespace Microsoft.ML.InternalCodeAnalyzer.Tests
    public sealed class TypeParamNameTest
    {
        [Fact]
+        [Obsolete]


Consider adding a message to the Obsolete attribute to specify the deprecation rationale or suggest an alternative, enhancing clarity for developers.

Suggested change

[Obsolete]

[Obsolete("This test method is deprecated and is retained for backward compatibility testing purposes.")]

tarekgh · 2025-05-05T23:41:36Z

eng/Versions.props

    <LightGBMVersion>4.6.0</LightGBMVersion>
+    <JsonSchemaNetGenerationVersion>5.0.1</JsonSchemaNetGenerationVersion>
+    <JsonSchemaNetVersion>7.3.4</JsonSchemaNetVersion>


What these used for? I mean why did we add these libraries dependency? These looks third party libraries, right?

They were always dependencies of dependencies. I added them in directly here so we could get the latest version and fix the nuget warnings. Would another way be better?

I am not sure this can cause issue the direct dependency expects lower version of these added references. @ericstj may advise about that

We should use in conjunction with CPM + transitive pinning. Adding all the direct PackageReferences are unnecessary that's what CPM will do for us - but we do need to list all package versions. @michaelgsharp Is there a reason we couldn't use CPM?

src/Microsoft.ML.AutoML/Microsoft.ML.AutoML.csproj

tarekgh · 2025-05-05T23:47:00Z

test/Microsoft.ML.CodeAnalyzer.Tests/Code/BestFriendOnPublicDeclarationTest.cs

@@ -19,6 +19,7 @@ public sealed class BestFriendOnPublicDeclarationTest
        private readonly Lazy<string> _sourceDeclaration = TestUtils.LazySource("BestFriendOnPublicDeclaration.cs");

        [Fact]
+        [Obsolete]
        public async Task BestFriendOnPublicDeclaration()


why we are obsoleting things in the tests? this is first time I see that :-)

We are going to be removing most, if not all, of our internal analyzers for ML.NET. They can pretty much all be handled by the formatting tools built into runtime now.

The problem is that the version update made a bunch of our analyzers use deprecated code, but because we are going to be removing them it's not worth the time to go update all the code itself, so I just added the obsolete tag to fix the error. Is there a better way to do that? I just figured removing the analyzers in this same PR would make this PR blow up in size and so I was trying to split things off.

Can't we suppress the analyzer warnings instead of adding obsolete?

tarekgh · 2025-05-05T23:49:28Z

test/Microsoft.ML.CodeAnalyzer.Tests/Helpers/CSharpCodeFixVerifier`2.cs

@@ -17,12 +17,15 @@ internal static class CSharpCodeFixVerifier<TAnalyzer, TCodeFix>
        where TAnalyzer : DiagnosticAnalyzer, new()
        where TCodeFix : CodeFixProvider, new()
    {
+        [System.Obsolete]
        public static DiagnosticResult Diagnostic()


nit: add using System above?

tarekgh · 2025-05-05T23:51:55Z

tools-local/Microsoft.ML.AutoML.SourceGenerator/EstimatorTypeGenerator.cs

@@ -15,6 +15,7 @@
 namespace Microsoft.ML.AutoML.SourceGenerator
 {
    [Generator]
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("MicrosoftCodeAnalysisCompatibility", "RS1042:Implementations of this interface are not allowed", Justification = "<Pending>")]
    public sealed class EstimatorTypeGenerator : ISourceGenerator


What Justification = "<Pending>" means?

Yeah, Copilot called that out too. I'm getting something added in shortly.

Write my name there 😄

codecov · 2025-05-06T01:36:24Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.98%. Comparing base (f6221d5) to head (7d95adc).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7457      +/-   ##
==========================================
- Coverage   68.99%   68.98%   -0.01%     
==========================================
  Files        1482     1482              
  Lines      273879   273879              
  Branches    28254    28254              
==========================================
- Hits       188965   188944      -21     
- Misses      77531    77547      +16     
- Partials     7383     7388       +5

Flag	Coverage Δ
Debug	`68.98% <ø> (-0.01%)`	⬇️
production	`63.27% <ø> (-0.01%)`	⬇️
test	`89.45% <ø> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...er.Tests/Code/BestFriendOnPublicDeclarationTest.cs	`100.00% <ø> (ø)`
...osoft.ML.CodeAnalyzer.Tests/Code/BestFriendTest.cs	`100.00% <ø> (ø)`
...t.ML.CodeAnalyzer.Tests/Code/ContractsCheckTest.cs	`100.00% <ø> (ø)`
...CodeAnalyzer.Tests/Code/InstanceInitializerTest.cs	`0.00% <ø> (-100.00%)`	⬇️
...t/Microsoft.ML.CodeAnalyzer.Tests/Code/NameTest.cs	`100.00% <ø> (ø)`
...deAnalyzer.Tests/Code/ParameterVariableNameTest.cs	`100.00% <ø> (ø)`
....ML.CodeAnalyzer.Tests/Code/RelaxTestNamingTest.cs	`32.18% <ø> (ø)`
...alyzer.Tests/Code/SingleVariableDeclarationTest.cs	`100.00% <ø> (ø)`
...ft.ML.CodeAnalyzer.Tests/Code/TypeParamNameTest.cs	`100.00% <ø> (ø)`
...eAnalyzer.Tests/Helpers/CSharpCodeFixVerifier`2.cs	`70.00% <ø> (ø)`

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

michaelgsharp added 2 commits May 5, 2025 17:07

version updates

a21d17c

rebase fixes

1eabe40

michaelgsharp requested review from Copilot, ericstj, tarekgh, LittleLittleCloud and JakeRadMSFT May 5, 2025 23:12

Copilot AI reviewed May 5, 2025

View reviewed changes

dotnet-policy-service bot assigned michaelgsharp May 5, 2025

tarekgh reviewed May 5, 2025

View reviewed changes

src/Microsoft.ML.AutoML/Microsoft.ML.AutoML.csproj Outdated Show resolved Hide resolved

tarekgh reviewed May 5, 2025

View reviewed changes

fix nuget warning

7d95adc

tarekgh approved these changes May 6, 2025

View reviewed changes

build-analysis bot mentioned this pull request May 6, 2025

AutoMLExperiment_return_current_best_trial_when_ct_is_canceled_with_trial_completed_Async fails in CI #7418

Open

LittleLittleCloud approved these changes May 7, 2025

View reviewed changes

ericstj assigned ericstj and unassigned michaelgsharp May 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dependency version updates #7457

Dependency version updates #7457

michaelgsharp commented May 5, 2025

Copilot AI left a comment

Copilot AI May 5, 2025

Copilot AI May 5, 2025

Copilot AI May 5, 2025

tarekgh May 5, 2025

michaelgsharp May 6, 2025

tarekgh May 6, 2025

ericstj May 6, 2025

tarekgh May 5, 2025

michaelgsharp May 6, 2025

tarekgh May 6, 2025

tarekgh May 5, 2025

tarekgh May 5, 2025

michaelgsharp May 6, 2025

tarekgh May 6, 2025

codecov bot commented May 6, 2025

	[Obsolete]
	[Obsolete("This test method is deprecated and is retained for backward compatibility testing purposes.")]

Dependency version updates #7457

Are you sure you want to change the base?

Dependency version updates #7457

Conversation

michaelgsharp commented May 5, 2025

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Copilot AI May 5, 2025

Choose a reason for hiding this comment

Copilot AI May 5, 2025

Choose a reason for hiding this comment

Copilot AI May 5, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented May 6, 2025

Codecov Report