[dotnet] shorten workload ids #12035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android#6045 We are aiming to simplify the .NET workload ids to short names like: dotnet workload install maui dotnet workload install android dotnet workload install ios dotnet workload install maccatalyst dotnet workload install macos dotnet workload install tvos Updated the workload ids here, as well as the `.stamp-install-workloads` make target. Other changes: * Updated descriptions to match Android. Still waiting on an *official* description we should be using for each workload. * Fixed trailing `,` that showed up as JSON errors in VS Code.
|
FYI this is for main/preview 7 only. /cc @GouriKumari |
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. |
rolfbjarne
approved these changes
Jun 29, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 112 tests passed 🎉Pipeline on Agent XAMBOT-1104.BigSur' |
mandel-macaque
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#6045
We are aiming to simplify the .NET workload ids to short names like:
Updated the workload ids here, as well as the
.stamp-install-workloadsmake target.
Other changes:
Updated descriptions to match Android. Still waiting on an official
description we should be using for each workload.
Fixed trailing
,that showed up as JSON errors in VS Code.