[msbuild] Fix building apps with extensions remotely. #23509

rolfbjarne · 2025-08-06T16:32:12Z

Currently blocked on:

https://dev.azure.com/devdiv/DevDiv/_git/ClientTools.Platform/commit/113b841c4a458a61ee3f985aa1a510bcaf196c82: this commit is breaking a test with plural RuntimeIdentifiers, because we build the outer build with one SessionId and then the inner build with another one, which means they'll be in different directories on the Mac, and then the outer build can't find the results from the inner build.

Fixes #23516.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2542958.

…ns. Fixes #23516. Don't override the GetTargetPath/Build/Rebuild targets for app extensions, because we also override some of these targets when building remotely, and the custom logic for app extensions is overridden. Instead create new targets that depend on those we previously overrode instead. Fixes #23516.

…onnection if a connection was established. This fixes a problem where a command-line build would hang because the remote connection would stay alive even after the build was completed.

vs-mobiletools-engineering-service2 · 2025-11-13T15:42:13Z

✅ [CI Build #cbfebb0] Build passed (Build packages) ✅

Pipeline on Agent
Hash: cbfebb0d40d80328355914ef79f3d58ea987005c [PR build]

vs-mobiletools-engineering-service2 · 2025-11-13T15:45:28Z

✅ [PR Build #cbfebb0] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: cbfebb0d40d80328355914ef79f3d58ea987005c [PR build]

vs-mobiletools-engineering-service2 · 2025-11-13T16:12:01Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: cbfebb0d40d80328355914ef79f3d58ea987005c [PR build]

vs-mobiletools-engineering-service2 · 2025-11-13T16:19:26Z

✅ [CI Build #cbfebb0] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: cbfebb0d40d80328355914ef79f3d58ea987005c [PR build]

vs-mobiletools-engineering-service2 · 2025-11-13T16:31:11Z

💻 [CI Build #cbfebb0] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: cbfebb0d40d80328355914ef79f3d58ea987005c [PR build]

vs-mobiletools-engineering-service2 · 2025-11-13T16:34:46Z

💻 [CI Build #cbfebb0] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: cbfebb0d40d80328355914ef79f3d58ea987005c [PR build]

vs-mobiletools-engineering-service2 · 2025-11-13T16:35:04Z

💻 [CI Build #cbfebb0] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: cbfebb0d40d80328355914ef79f3d58ea987005c [PR build]

vs-mobiletools-engineering-service2 · 2025-11-13T16:36:07Z

💻 [CI Build #cbfebb0] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: cbfebb0d40d80328355914ef79f3d58ea987005c [PR build]

vs-mobiletools-engineering-service2 · 2025-11-13T16:57:46Z

💻 [CI Build #cbfebb0] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: cbfebb0d40d80328355914ef79f3d58ea987005c [PR build]

vs-mobiletools-engineering-service2 · 2025-11-13T17:38:44Z

🔥 [CI Build #cbfebb0] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 4 tests failed, 111 tests passed.

Failures

❌ fsharp tests

1 tests failed, 3 tests passed.

fsharp/tvOS - simulator/Debug: Crashed

Html Report (VSDrops) Download

❌ interdependent-binding-projects tests

1 tests failed, 3 tests passed.

interdependent-binding-projects/tvOS - simulator/Debug: Crashed

Html Report (VSDrops) Download

❌ windows tests

1 tests failed, 0 tests passed.

Html Report (VSDrops) Download

❌ xcframework tests

1 tests failed, 3 tests passed.

xcframework-test/tvOS - simulator/Debug: Crashed

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: cbfebb0d40d80328355914ef79f3d58ea987005c [PR build]

This comment has been minimized.

Sign in to view

rolfbjarne force-pushed the dev/rolf/fix-building-extensions-on-remote-windows branch from 1a105b2 to 23e23e6 Compare November 11, 2025 09:37

This comment has been minimized.

Sign in to view

rolfbjarne added 3 commits November 13, 2025 16:04

[msbuild] Update 'IsRemoteBuild' to build app extensions remotely.

6dcd132

[msbuild] Bump messaging to get a fix for always closing the remote c…

cbfebb0

…onnection if a connection was established. This fixes a problem where a command-line build would hang because the remote connection would stay alive even after the build was completed.

rolfbjarne force-pushed the dev/rolf/fix-building-extensions-on-remote-windows branch from 23e23e6 to cbfebb0 Compare November 13, 2025 15:06

[msbuild] Fix building apps with extensions remotely. #23509

Are you sure you want to change the base?

[msbuild] Fix building apps with extensions remotely. #23509

Uh oh!

Conversation

rolfbjarne commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Nov 13, 2025

✅ [CI Build #cbfebb0] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 13, 2025

✅ [PR Build #cbfebb0] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 13, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 13, 2025

✅ [CI Build #cbfebb0] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 13, 2025

💻 [CI Build #cbfebb0] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 13, 2025

💻 [CI Build #cbfebb0] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 13, 2025

💻 [CI Build #cbfebb0] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 13, 2025

💻 [CI Build #cbfebb0] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Nov 13, 2025

rolfbjarne commented Aug 6, 2025 •

edited

Loading