[Foundation] Fix nullability in NSUrlDownload. #24275
Conversation
This is file 14 of 47 files with nullability disabled in Foundation. Changes: - Enabled nullable reference types - Replaced "To be added." XML documentation with proper documentation for ToString() method - Added see cref attribute for better cross-referencing - Removed unnecessary whitespace in XML comments Also removed the NSUrlDownload.ToString method, it was supposed to fix a crash over 10 years ago, and that crash no longer occurs. Contributes towards #17285.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull Request Overview
This PR enables nullable reference types for the NSUrlDownload partial class in Foundation, which is part of an ongoing effort to fix nullability across 47 files in the Foundation namespace. The entire partial class is wrapped in a conditional compilation directive to exclude it from XAMCORE_5_0 builds, scheduling it for removal in the next major version.
- Enabled nullable reference types with
#nullable enable - Updated XML documentation from placeholder "To be added" text to proper documentation
- Wrapped the entire partial class in
#if !XAMCORE_5_0to schedule it for removal in XAMCORE_5_0
…ullability-14-nsurldownload
✅ [CI Build #65b08d5] Build passed (Build packages) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #65b08d5] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #65b08d5] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #65b08d5] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [CI Build #65b08d5] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #65b08d5] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #65b08d5] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
💻 [CI Build #65b08d5] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
🚀 [CI Build #65b08d5] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 130 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This is file 14 of 47 files with nullability disabled in Foundation.
Changes:
Also removed the NSUrlDownload.ToString method, it was supposed to fix a crash
over 10 years ago, and that crash no longer occurs.
Contributes towards #17285.