[Foundation] Fix nullability in NSTimeZone. #24304
Conversation
This is file 17 of 47 files with nullability disabled in Foundation. Changes: - Enabled nullable reference types - Made known_time_zone_names field nullable since it's lazily initialized - Replaced "To be added." XML documentation with proper documentation for KnownTimeZoneNames property - Added see cref attributes for better cross-referencing - Removed unnecessary whitespace in XML comments - Improved ToString() documentation with clearer description and proper formatting Contributes towards #17285.
There was a problem hiding this comment.
Pull Request Overview
This PR enables nullable reference types for the NSTimeZone class in Foundation, contributing to the broader effort to enable nullability across the Foundation namespace (issue #17285).
- Enabled nullable reference types by adding
#nullable enabledirective - Corrected nullability annotation for the lazily-initialized
known_time_zone_namesfield - Replaced placeholder XML documentation with meaningful descriptions and proper
<see cref>cross-references
✅ [CI Build #3f51c63] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #3f51c63] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #3f51c63] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #3f51c63] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [CI Build #3f51c63] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #3f51c63] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #3f51c63] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #3f51c63] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #3f51c63] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 124 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This is file 17 of 47 files with nullability disabled in Foundation.
Changes:
Contributes towards #17285.