Skip to content

Conversation

@rolfbjarne
Copy link
Member

Fixes #21537.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for the NSUrlSessionHandler.MaxInputInMemory property, replacing the placeholder "To be added" comments with comprehensive documentation explaining how the property controls whether request content is sent in memory or via streaming, and how this affects HTTP headers.

Key Changes

  • Documented the behavior of MaxInputInMemory property including its effect on Content-Length headers and chunked encoding
  • Explained the trade-offs between in-memory and streaming content delivery
  • Added guidance on when to use different values for the property

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne requested a review from Copilot November 20, 2025 12:00
Copilot finished reviewing on behalf of rolfbjarne November 20, 2025 12:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #c01cdf8] Build passed (Build packages) ✅

Pipeline on Agent
Hash: c01cdf85983171d09ffc8bfcc2fc3f1bef0b0ddf [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #c01cdf8] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: c01cdf85983171d09ffc8bfcc2fc3f1bef0b0ddf [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: c01cdf85983171d09ffc8bfcc2fc3f1bef0b0ddf [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #c01cdf8] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: c01cdf85983171d09ffc8bfcc2fc3f1bef0b0ddf [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #c01cdf8] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: c01cdf85983171d09ffc8bfcc2fc3f1bef0b0ddf [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #c01cdf8] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: c01cdf85983171d09ffc8bfcc2fc3f1bef0b0ddf [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #c01cdf8] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: c01cdf85983171d09ffc8bfcc2fc3f1bef0b0ddf [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #c01cdf8] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: c01cdf85983171d09ffc8bfcc2fc3f1bef0b0ddf [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #c01cdf8] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: c01cdf85983171d09ffc8bfcc2fc3f1bef0b0ddf [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne enabled auto-merge (squash) November 21, 2025 07:51
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #c01cdf8] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: c01cdf85983171d09ffc8bfcc2fc3f1bef0b0ddf [PR build]

@rolfbjarne rolfbjarne merged commit 7bcb04b into main Nov 21, 2025
50 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upload Progress with ProgressMessageHandler Completes Unexpectedly

4 participants