Skip to content

Improve screen reader text readability for Delete buttons #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

Improve screen reader text readability for Delete buttons #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions 10.0/Apps/DeveloperBalance/Pages/ManageMetaPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
Background="Transparent"
Command="{Binding DeleteCategoryCommand, Source={RelativeSource AncestorType={x:Type pageModels:ManageMetaPageModel}}, x:DataType=pageModels:ManageMetaPageModel}" CommandParameter="{Binding .}"
Grid.Column="3"
SemanticProperties.Description="Delete Category" />
SemanticProperties.Description="{Binding Title, StringFormat='Delete {0} Category'}" />
</Grid>
</DataTemplate>
</BindableLayout.ItemTemplate>
Expand Down Expand Up @@ -116,7 +116,7 @@

<Button
ImageSource="{StaticResource IconDelete}"
SemanticProperties.Description="Delete Tag"
SemanticProperties.Description="{Binding Title, StringFormat='Delete {0} Tag'}"
Background="Transparent"
Command="{Binding DeleteTagCommand, Source={RelativeSource AncestorType={x:Type pageModels:ManageMetaPageModel}}, x:DataType=pageModels:ManageMetaPageModel}" CommandParameter="{Binding .}"
Grid.Column="3"/>
Expand Down
2 changes: 1 addition & 1 deletion 10.0/Apps/DeveloperBalance/Pages/ProjectDetailPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
Order="Primary"
Priority="0"
IconImageSource="{StaticResource IconDelete}"
SemanticProperties.Description="Delete" />
SemanticProperties.Description="Delete Project" />
</ContentPage.ToolbarItems>

<Grid>
Expand Down
2 changes: 1 addition & 1 deletion 10.0/Apps/DeveloperBalance/Pages/TaskDetailPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
Order="Primary"
Priority="0"
IconImageSource="{StaticResource IconDelete}"
SemanticProperties.Description="Delete" />
SemanticProperties.Description="Delete Task" />
</ContentPage.ToolbarItems>

<Grid>
Expand Down
4 changes: 2 additions & 2 deletions 9.0/Apps/DeveloperBalance/Pages/ManageMetaPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
Background="Transparent"
Command="{Binding DeleteCategoryCommand, Source={RelativeSource AncestorType={x:Type pageModels:ManageMetaPageModel}}, x:DataType=pageModels:ManageMetaPageModel}" CommandParameter="{Binding .}"
Grid.Column="3"
SemanticProperties.Description="Delete Category" />
SemanticProperties.Description="{Binding Title, StringFormat='Delete {0} Category'}" />
</Grid>
</DataTemplate>
</BindableLayout.ItemTemplate>
Expand Down Expand Up @@ -116,7 +116,7 @@

<Button
ImageSource="{StaticResource IconDelete}"
SemanticProperties.Description="Delete Tag"
SemanticProperties.Description="{Binding Title, StringFormat='Delete {0} Tag'}"
Background="Transparent"
Command="{Binding DeleteTagCommand, Source={RelativeSource AncestorType={x:Type pageModels:ManageMetaPageModel}}, x:DataType=pageModels:ManageMetaPageModel}" CommandParameter="{Binding .}"
Grid.Column="3"/>
Expand Down
2 changes: 1 addition & 1 deletion 9.0/Apps/DeveloperBalance/Pages/ProjectDetailPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
Order="Primary"
Priority="0"
IconImageSource="{StaticResource IconDelete}"
SemanticProperties.Description="Delete" />
SemanticProperties.Description="Delete Project" />
</ContentPage.ToolbarItems>

<Grid>
Expand Down
2 changes: 1 addition & 1 deletion 9.0/Apps/DeveloperBalance/Pages/TaskDetailPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
Order="Primary"
Priority="0"
IconImageSource="{StaticResource IconDelete}"
SemanticProperties.Description="Delete" />
SemanticProperties.Description="Delete Task" />
</ContentPage.ToolbarItems>

<Grid>
Expand Down
Loading