Skip to content

[Android] Removes freeze using SecureStorage #17928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 6, 2023
Merged

[Android] Removes freeze using SecureStorage #17928

merged 4 commits into from
Nov 6, 2023

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Oct 10, 2023 •
edited
Loading

Description of Change

Removes freeze using SecureStorage on Android.

image

Issues Fixed

Fixes #17706
Fixes #18685
FIxes #18817

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/android area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info labels Oct 10, 2023
@jsuarezruiz jsuarezruiz changed the title [Android] Removes lock using SecureStorage [Android] Removes freeze using SecureStorage Oct 10, 2023
@jsuarezruiz jsuarezruiz marked this pull request as ready for review October 11, 2023 07:16
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner October 11, 2023 07:16
mattleibow
mattleibow reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do the same for the Set?

@samhouts samhouts added this to the .NET 8 SR1 milestone Oct 12, 2023
@jsuarezruiz
Copy link
Contributor Author

Can we do the same for the Set?

Sure, done. Could you take another look?. Thanks in advance.

@mattleibow mattleibow merged commit b690d3a into main Nov 6, 2023
@mattleibow mattleibow deleted the fix-17706 branch November 6, 2023 15:39
@jsuarezruiz jsuarezruiz mentioned this pull request Nov 13, 2023
Open
@Redth Redth mentioned this pull request Nov 13, 2023
Closed
@jsuarezruiz jsuarezruiz mentioned this pull request Nov 17, 2023
Open
@phillippschmedt phillippschmedt mentioned this pull request Nov 17, 2023
Closed
@phillippschmedt
Copy link

phillippschmedt commented Nov 17, 2023 •
edited
Loading

Can you please give an estimation on when this will be released? This is ESSENTIAL!! for our app.

@mattleibow
Copy link
Member

This will go out with SR1.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
@samhouts samhouts added the fixed-in-8.0.6 Look for this fix in 8.0.6 SR1! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info fixed-in-8.0.6 Look for this fix in 8.0.6 SR1! platform/android t/bug Something isn't working
Projects
None yet
Milestone
.NET 8 SR1
4 participants
@jsuarezruiz @phillippschmedt @mattleibow @samhouts