-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Windows] Fix FontImageSource resize behavior #21212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
src/Controls/samples/Controls.Sample.UITests/Issues/Issue21202.xaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| <?xml version="1.0" encoding="utf-8" ?> | ||
| <ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui" | ||
| xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml" | ||
| x:Class="Maui.Controls.Sample.Issues.Issue21202" | ||
| Title="Issue 21202"> | ||
| <VerticalStackLayout | ||
| Padding="12" | ||
| Grid.Column="1"> | ||
| <Label | ||
| AutomationId="WaitForStubControl" | ||
| Text="1. Font image source should not be stretched on button with height requested."/> | ||
| <Button | ||
| FontSize="18" | ||
| HeightRequest="60" | ||
| HorizontalOptions="Fill" | ||
| Text="Button with height request set" | ||
| TextTransform="Uppercase" | ||
| FontFamily="OpenSansRegular"> | ||
| <Button.ImageSource> | ||
| <FontImageSource Glyph="A" Color="Black" FontFamily="OpenSansRegular"/> | ||
| </Button.ImageSource> | ||
| </Button> | ||
| <Label | ||
| Text="2. Font image source should not be stretched on button without height requested."/> | ||
| <Button | ||
| FontSize="18" | ||
| HorizontalOptions="Fill" | ||
| Text="Button without height request" | ||
| TextTransform="Uppercase" | ||
| FontFamily="OpenSansRegular"> | ||
| <Button.ImageSource> | ||
| <FontImageSource Glyph="A" Color="Black" FontFamily="OpenSansRegular"/> | ||
| </Button.ImageSource> | ||
| </Button> | ||
| <Label | ||
| Text="3. Button without height request should resize to font image source size."/> | ||
| <Button | ||
| FontSize="18" | ||
| HorizontalOptions="Fill" | ||
| Text="Button without height request, resize to font image" | ||
| TextTransform="Uppercase" | ||
| FontFamily="OpenSansRegular"> | ||
| <Button.ImageSource> | ||
| <FontImageSource Glyph="A" Size="60" Color="Black" FontFamily="OpenSansRegular"/> | ||
| </Button.ImageSource> | ||
| </Button> | ||
| </VerticalStackLayout> | ||
| </ContentPage> |
15 changes: 15 additions & 0 deletions
15
src/Controls/samples/Controls.Sample.UITests/Issues/Issue21202.xaml.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| using Microsoft.Maui.Controls; | ||
| using Microsoft.Maui.Controls.Xaml; | ||
|
|
||
| namespace Maui.Controls.Sample.Issues | ||
| { | ||
| [XamlCompilation(XamlCompilationOptions.Compile)] | ||
| [Issue(IssueTracker.Github, 21202, "FontImageSource incorrectly sized", PlatformAffected.UWP)] | ||
| public partial class Issue21202 : ContentPage | ||
| { | ||
| public Issue21202() | ||
| { | ||
| InitializeComponent(); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+94.7 KB
src/Controls/samples/Controls.Sample.UITests/Resources/Fonts/OpenSans-Regular.ttf
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.AppiumTests.Issues | ||
| { | ||
| public class Issue21202 : _IssuesUITest | ||
| { | ||
| public Issue21202(TestDevice device) : base(device) | ||
| { | ||
| } | ||
|
|
||
| public override string Issue => "FontImageSource incorrectly sized"; | ||
|
|
||
| [Test] | ||
| public void Issue21202Test() | ||
| { | ||
| this.IgnoreIfPlatforms(new TestDevice[] { TestDevice.Android, TestDevice.Mac, TestDevice.iOS }, "Only Windows for now"); | ||
|
|
||
| App.WaitForElement("WaitForStubControl"); | ||
|
|
||
| VerifyScreenshot(); | ||
| } | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be a new page? I just finished up the Android fixes and if there are 2 columns this page will be too narrow and cramped for a good test on android/ios
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's probably a good idea.