Fix iOS log exports#23334
Merged
Merged
Conversation
PureWeen
added
the
area-infrastructure
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
/rebase |
PureWeen
force-pushed
the
fix_device_logging
branch
from
5b9be05 to
19c910a
Compare
PureWeen
changed the title
PureWeen
force-pushed
the
fix_device_logging
branch
from
19c910a to
0354908
Compare
PureWeen
changed the title
PureWeen
requested review from
jsuarezruiz,
mattleibow and
rmarinho
and removed request for
jsuarezruiz and
rmarinho
rolfbjarne
previously approved these changes
Jul 8, 2024
Member
|
/rebase |
github-actions
Bot
force-pushed
the
fix_device_logging
branch
from
cdfd028 to
d6fa3a2
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
force-pushed
the
fix_device_logging
branch
from
13a3ef1 to
2b0dbbe
Compare
pictos
pushed a commit
to pictos/maui
that referenced
this pull request
Jul 22, 2024
[Windows] Fix CollectionView DisconnectHandler SelectionMode Crash (dotnet#23726) * Reorder events to prevent disconnect issues * Add test --------- Co-authored-by: Mike Corsaro <mikecorsaro@microsoft.com> Use UIView.Window instead of the global window (dotnet#23693) [Windows] Subscribe pointer events only when needed (dotnet#23515) Fix iOS log exports (dotnet#23334) * Fix ios Device Logging * - fix up device test logging a bit more * Update ui-tests-steps.yml * Update ui-tests-steps.yml * Update ios.cake * Update ui-tests-steps.yml * Update maui-templates.yml * Update maui-templates.yml remove code from oldFragment add new shiny DialogFragment refactoring code to find and dismiss DialogFragment code cleanup delete ModalContainer to use only ModalFragment handle animation and add a map between page and dialogFragment We've back button enabled! After dismissing several demons summoned using obscure Android APIs, I was able to deal with the BackButtonPressed event add modal animations as anim.xml files using cleanup remowork PopModalPlatformAsync to work with dialogFragment remove tag final adjustments on DialogFragment change the ShowNow for Show to fix the issue Wait for animation to complete change local functions order fix build create window hooks for android (like iOS) clean up ModalFragment fields change Dictionary to ConditionalWeakTable clean up event animation refactor on Null notation remove comments - adjust back button - different back button code style remove unused prop. fix DontPushModalPagesWhenWindowIsDeactivated DeviceTest completes the task return back the way how modalManager handles android modals normilize animation duration Co-authored-by: Shane Neuville <shane94@hotmail.com> remove focusability code change how fragments are looked-up code style
Member
Author
|
/backport to net9.0 |
Contributor
|
Started backporting to net9.0: https://github.com/dotnet/maui/actions/runs/10062515188 |
samhouts
added
fixed-in-net9.0-nightly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
At one point we added code to collect all the iOS console logs when running tests. AFAICT none of those added steps successfully gather the logs during test runs. Because the iOS devices are created and then destroyed within the scope of the test run, the device logs no longer exist after the run has finished. This PR should now grab only the logs we care about.