[android]: ModalContainer Destroy commit allowing state loss#23400
Conversation
|
Hey there @rs-lkroneman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
@dotnet-policy-service agree company="Ramsey Solutions" |
| App.ForegroundApp(); | ||
| App.WaitForElement("OpenModal"); | ||
| } | ||
| catch |
There was a problem hiding this comment.
We don't need these bits anymore
We had to do this before we were just restarting the app between every test
So, you're fine to just remove this try/catch
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| { | ||
| public override string Issue => "Closing Modal While App is Backgrounded Fails"; | ||
|
|
||
| [Test] |
There was a problem hiding this comment.
| [Test] | |
| [Test] | |
| [Category(UITestCategories.Navigation)] |
| { | ||
| public override string Issue => "Closing Modal While App is Backgrounded Fails"; | ||
|
|
||
| [Test] |
There was a problem hiding this comment.
We'll need to add a Category to this before merging. We recently merged some changes that requires every test to have a Category
I would add it myself, but, it looks like I don't have permission to make changes.
There was a problem hiding this comment.
@PureWeen it's probably because I forked the repository into our organization's workspace.
Added the category.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
samhouts
added
fixed-in-net9.0-nightly
3 participants
Description of Change
While an animation is in progress and the app is backgrounded the app crashes with an java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState
This is currently our number 1 exception in production.
All of our stack traces point to the ModalContainer.Destroy() method
Issues Fixed
Android crashes on Modal Animation when backgrounded
Fixes #23399