Skip to content

Make sure resizetized image files are writable #23412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmarinho merged 1 commit into from
Jul 15, 2024
Merged

Make sure resizetized image files are writable #23412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/SingleProject/Resizetizer/src/ResizetizeImages.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,10 @@ public override System.Threading.Tasks.Task ExecuteAsync()
attr.Add("_ResizetizerDpiScale", img.Dpi.Scale.ToString("0.0", CultureInfo.InvariantCulture));

copiedResources.Add(new TaskItem(itemSpec, attr));
// Make sure the file is not readonly
Utils.SetWriteable(itemSpec);
// force the date time so we never update an image if its not changed.
File.SetLastWriteTimeUtc (itemSpec, DateTime.UtcNow);
File.SetLastWriteTimeUtc(itemSpec, DateTime.UtcNow);
}

CopiedResources = copiedResources.ToArray();
Expand Down
10 changes: 10 additions & 0 deletions src/SingleProject/Resizetizer/src/Utils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,15 @@ public static (bool Exists, DateTime Modified) FileExists(string path)
var modified = exists ? File.GetLastWriteTimeUtc(path) : System.DateTime.MinValue;
return (exists, modified);
}

public static void SetWriteable(string source, bool checkExists = true)
{
if (checkExists && !File.Exists(source))
return;

var attributes = File.GetAttributes(source);
if ((attributes & FileAttributes.ReadOnly) == FileAttributes.ReadOnly)
File.SetAttributes(source, attributes & ~FileAttributes.ReadOnly);
}
}
}