Skip to content

Don't throw exceptions on back-to-back window deactivations #23519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 3 commits into from
Jul 13, 2024
Merged

Don't throw exceptions on back-to-back window deactivations #23519

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e837622
Don't throw exceptions on back-to-back window deactivations, as this …
Jul 9, 2024
1c47d3f
Switch activation logic check to be in MauiWinUIWindow
Jul 10, 2024
768a4d7
Clarify comment
Foda Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Core/src/Platform/Windows/MauiWinUIWindow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,13 @@ protected virtual void OnActivated(object sender, UI.Xaml.WindowActivatedEventAr
else
_enableResumeEvent = true;
}
else if (args.WindowActivationState == UI.Xaml.WindowActivationState.Deactivated &&
!_isActivated)
{
// Don't invoke deactivated event if we're not activated. It's possible we can
// recieve this event twice if we start more than one process at a time

@PureWeen PureWeen Jul 11, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would two processes be using the same MauiWinUIWindow?

@Foda Foda Jul 11, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, they're not the same MauiWinUIWindow: starting any process that has a window will send a window message back to the window of the process that started it:
image

return;
}
else
{
_isActivated = false;
Expand Down