Use explicit platform versions#23966
Closed
mattleibow wants to merge 1 commit into
Closed
Conversation
This is used to avoid the case where some SDKs bump their platform version and we end up forcing the entire ecosystem to update SDKs.
mattleibow
force-pushed
the
dev/platform-versions
branch
from
f789b83 to
ca53e1b
Compare
| <TvosTargetFrameworkVersion>16.1</TvosTargetFrameworkVersion> | ||
| <MacCatalystTargetFrameworkVersion>16.1</MacCatalystTargetFrameworkVersion> | ||
| <MacosTargetFrameworkVersion>13.0</MacosTargetFrameworkVersion> | ||
| <AndroidTargetFrameworkVersion>33.0</AndroidTargetFrameworkVersion> |
Member
There was a problem hiding this comment.
34 is the default in .NET 8. If you take this to the .NET 9 branch, you'll want to change it to 35.
Member
Author
There was a problem hiding this comment.
Yeah, that will have to be done.
Member
Author
|
Moving this to draft as I think the other PR is better: #23995 But, this one will also work if we need it ASAP and the other PR is failing. I tested this PR and it seems to work nicely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This is used to avoid the case where some SDKs bump their platform version and we end up forcing the entire ecosystem to update SDKs.
This just updates the library projects to use explicit versions, all the sample and tests apps still use the unversioned TFMs like a typical dev would.
Probably a better PR that splits the version into old SDK vs new SDK: #23995