Remove the 'Resources' prefix from BundleResource#23978
Merged
Conversation
jonathanpeppers
left a comment
jonathanpeppers
left a comment
Member
There was a problem hiding this comment.
Can we add a template-style test, that includes a @(BundleResource) of each type that should work?
jfversluis
previously approved these changes
Aug 5, 2024
rolfbjarne
previously approved these changes
Aug 5, 2024
Member
|
/backport to release/8.0.1xx-sr7 |
Fixes #23554 Prior to Maui 8.0.70, there was a bug that only removed the "Resources/" prefix, and not the correct "Platforms/iOS/Resource": #16734 This PR #23269 fixes the original issue, but now exposed the case where BundleResource were included in the root Resources folder instead of the Platforms/iOS/ folder.
Member
Author
|
#24015 succeeded and was merged. |
Member
|
/backport to release/9.0.1xx-preview7 |
Contributor
|
Started backporting to release/9.0.1xx-preview7: https://github.com/dotnet/maui/actions/runs/10257553522 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Prior to Maui 8.0.70, there was a bug that only removed the "Resources/" prefix, and not the correct "Platforms/iOS/Resources/": #16734
The PR #23269 fixes the original issue, but now exposed the case where
@(BundleResource)were included in the root "Resources" folder instead of the "Platforms/iOS/Resources" folder.Issues Fixed
Fixes #23554