Skip to content

Fixes Android FontModel Glide In-Memory Caching#24021

Merged
PureWeen merged 1 commit into
dotnet:mainfrom
albyrock87:fix-android-glide-fontmodel-caching
Aug 5, 2024
Merged

Fixes Android FontModel Glide In-Memory Caching#24021
PureWeen merged 1 commit into
dotnet:mainfrom
albyrock87:fix-android-glide-fontmodel-caching

Conversation

@albyrock87

Copy link
Copy Markdown
Contributor

Description of Change

Thanks to additional logging I've discovered FontModel-related images are not being cached in memory.

https://bumptech.github.io/glide/tut/custom-modelloader.html#implementing-buildloaddata

A Key that will be used as part of our disk cache keys (the model’s equals() and hashCode() methods are used for the in memory cache key).

Without this fix we're filling up the memory cache with identical FontModels.
This brings a very good improvement with applications using FontIconSource.

Issues Fixed

Slightly improves #6625 on FontIconSource by fixing the non-working in-memory cache (which has synchronous loading).

@albyrock87 albyrock87 requested a review from a team as a code owner August 5, 2024 17:00
@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label Aug 5, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hey there @albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@mattleibow mattleibow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

I wonder if this helps with this: #22757

@mattleibow

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen

PureWeen commented Aug 5, 2024

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen merged commit 7cb2341 into dotnet:main Aug 5, 2024
@albyrock87 albyrock87 deleted the fix-android-glide-fontmodel-caching branch August 6, 2024 06:37
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community ✨ Community Contribution fixed-in-8.0.80

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants