Skip to content

[android] call PlatformContentViewGroup.postInvalidate() less #24222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 2 commits into from
Aug 14, 2024
Merged

[android] call PlatformContentViewGroup.postInvalidate() less #24222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e984c9
[android] call `PlatformContentViewGroup.postInvalidate()` less
jonathanpeppers Aug 13, 2024
eb5fae2
Apply same change for `WrapperView.setHasShadow()`
jonathanpeppers Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Core/AndroidNative/maui/src/main/java/com/microsoft/maui/PlatformContentViewGroup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,10 @@ public PlatformContentViewGroup(Context context, AttributeSet attrs, int defStyl
* @param hasClip
*/
protected final void setHasClip(boolean hasClip) {
this.hasClip = hasClip;
postInvalidate();
if (this.hasClip != hasClip) {
this.hasClip = hasClip;
postInvalidate();
}
}

@Override
Expand Down
6 changes: 4 additions & 2 deletions src/Core/AndroidNative/maui/src/main/java/com/microsoft/maui/PlatformWrapperView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@ public PlatformWrapperView(Context context) {
* @param hasShadow
*/
protected final void setHasShadow(boolean hasShadow) {
this.hasShadow = hasShadow;
postInvalidate();
if (this.hasShadow != hasShadow) {
this.hasShadow = hasShadow;
postInvalidate();
}
}

@Override
Expand Down
Binary file modified src/Core/src/maui.aar
View file
Open in desktop
Binary file not shown.