Skip to content

[X] Match behavior of compiled bindings with indexers to their non-compiled counterparts#24229

Merged
rmarinho merged 2 commits into
dotnet:mainfrom
simonrozsival:fix-compiled-binding-indexer-handlers-array
Aug 21, 2024
Merged

[X] Match behavior of compiled bindings with indexers to their non-compiled counterparts#24229
rmarinho merged 2 commits into
dotnet:mainfrom
simonrozsival:fix-compiled-binding-indexer-handlers-array

Conversation

@simonrozsival

Copy link
Copy Markdown
Member

Description of Change

Non-compiled bindings with indexers are reaplied when the PropertyChanged event is raised for both "Item" and "Item[idx]" property names. Compiled bindings only react to changes to the "Item[idx]" variant.

Issues Fixed

Fixes #23621

/cc @StephaneDelcroix

@rmarinho rmarinho merged commit 3369893 into dotnet:main Aug 21, 2024
Redth pushed a commit that referenced this pull request Aug 22, 2024
…mpiled counterparts (#24229)

* Add test

* Fix generated handlers array to match Debug behavior
@samhouts samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Aug 27, 2024
@samhouts samhouts added fixed-in-9.0.0-rc.1.24453.9 and removed fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Sep 20, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OnPropertyChanged("Item") invalid in 'Release' mode

4 participants