-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Implementation of Customizable Search Button Color for SearchBar Across Platforms #26759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
656d81c
Implementation changes
praveenkumarkarunanithi 9c23e06
Test case commit
praveenkumarkarunanithi d48fa4b
UI test images commit
praveenkumarkarunanithi 0cf5fef
XML comment update
praveenkumarkarunanithi 033cc39
Merge branch 'dotnet:main' into fix-22963
praveenkumarkarunanithi c746507
updating device test class with SearchButtonColor property.
praveenkumarkarunanithi 837f227
removing conflicted line of code
praveenkumarkarunanithi 6be7ae3
Merge branch 'dotnet:main' into fix-22963
praveenkumarkarunanithi 4d1bbe3
re commit the fix line after resolving conflict.
praveenkumarkarunanithi 2736158
Update PublicAPI.Unshipped.txt
praveenkumarkarunanithi e69d680
Update PublicAPI.Unshipped.txt
praveenkumarkarunanithi ad2b697
commit for UI test case images.
praveenkumarkarunanithi 46cab6c
modified API name as per its functionality
praveenkumarkarunanithi 13e917e
Update Issue22963.cs
praveenkumarkarunanithi 98448cf
updatedtestcase Screenshot name
praveenkumarkarunanithi d083ab2
updated test case naming
praveenkumarkarunanithi bf162bf
Update SearchBar.cs
praveenkumarkarunanithi 7914c1d
name update
praveenkumarkarunanithi c1af9e2
resolving conflicts
praveenkumarkarunanithi 1aee8c0
Update PublicAPI.Unshipped.txt
praveenkumarkarunanithi a2edf7e
Merge branch 'dotnet:main' into fix-22963
praveenkumarkarunanithi 280213b
resolved branch conflicts
praveenkumarkarunanithi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+7.96 KB
...Cases.Android.Tests/snapshots/android/SearchButtonColorInitializesCorrectly.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| namespace Maui.Controls.Sample.Issues | ||
| { | ||
| [XamlCompilation(XamlCompilationOptions.Compile)] | ||
| [Issue(IssueTracker.Github, 22963, "Implementation of Customizable Search Button Color for SearchBar Across Platforms", PlatformAffected.All)] | ||
|
|
||
| public partial class Issue22963 : ContentPage | ||
| { | ||
| public Issue22963() | ||
| { | ||
| ConfigureSearchBar(); | ||
| } | ||
|
|
||
| private void ConfigureSearchBar() | ||
| { | ||
| // Create the SearchBar | ||
| var searchBar = new SearchBar | ||
| { | ||
| Placeholder = "Search...", | ||
| SearchButtonColor = Colors.Magenta, | ||
| WidthRequest = 300, | ||
| HorizontalOptions = LayoutOptions.Center, | ||
| VerticalOptions = LayoutOptions.Start, | ||
| AutomationId = "SearchBar" | ||
| }; | ||
|
|
||
| // Add the SearchBar to the layout | ||
| var layout = new Grid(); | ||
| layout.Children.Add(searchBar); | ||
|
|
||
| // Set the layout as the Content of the page | ||
| Content = layout; | ||
| } | ||
| } | ||
| } |
Binary file added
BIN
+43.4 KB
...sts/TestCases.Mac.Tests/snapshots/mac/SearchButtonColorInitializesCorrectly.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions
21
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22963.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues | ||
| { | ||
| internal class Issue22963 : _IssuesUITest | ||
| { | ||
| public Issue22963(TestDevice device) : base(device) { } | ||
|
|
||
| public override string Issue => "Implementation of Customizable Search Button Color for SearchBar Across Platforms"; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.SearchBar)] | ||
| public void SearchButtonColorInitializesCorrectly() | ||
| { | ||
| App.WaitForElement("SearchBar"); | ||
| VerifyScreenshot(); | ||
| } | ||
| } | ||
| } |
Binary file added
BIN
+5.84 KB
...stCases.WinUI.Tests/snapshots/windows/SearchButtonColorInitializesCorrectly.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+19.2 KB
...sts/TestCases.iOS.Tests/snapshots/ios/SearchButtonColorInitializesCorrectly.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.