ScrollView CrossPlatformMeasure - refactor #27085
Conversation
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| if (double.IsInfinity(widthConstraint)) | ||
| { | ||
| widthConstraint = result.Width; | ||
| widthConstraint = contentSize.Width; |
There was a problem hiding this comment.
Do we want to delete both of these if checks on Android and Windows?
There was a problem hiding this comment.
Without them AdjustForFill doesn't work correctly
|
@kubaflo Does this PR potentially improve performance please? |
I hope so, but I didn't measure anything. The main idea was to uniform the code across the platforms |
kubaflo
force-pushed
the
scroll-view-refactor
branch
from
e44c057 to
74be47b
Compare
kubaflo
force-pushed
the
scroll-view-refactor
branch
from
74be47b to
383e3d4
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CrossPlatformMeasure method for ScrollViewHandler on Android and Windows to align with the iOS implementation introduced in a previous PR. The changes include code improvements, spelling corrections, bug fixes, and extensive localization updates.
Key changes include:
- Refactoring of BlazorWebView components with improved request handling and platform-specific optimizations
- Correction of spelling errors in logging methods (
ReponseContentNotFound→ResponseContentNotFound) - Addition of new test files for BlazorWebView functionality across different scenarios
- Extensive localization updates across multiple languages and template files
Reviewed Changes
Copilot reviewed 289 out of 2334 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/BlazorWebView/tests/MauiDeviceTests/Elements/BlazorWebViewTests.*.cs |
New test files for BlazorWebView covering navigation, logging, components, and behaviors |
src/BlazorWebView/src/SharedSource/WebView2WebViewManager.cs |
Updated request filtering and fixed logging method name |
src/BlazorWebView/src/SharedSource/Log.cs |
Corrected method name spelling |
src/BlazorWebView/src/Maui/iOS/IOSWebViewManager.cs |
Platform-specific improvements and bounce scrolling disabled by default |
src/BlazorWebView/src/Maui/Windows/WinUIWebViewManager.cs |
Enhanced request handling with logging improvements |
src/BlazorWebView/src/Maui/Android/WebKitWebViewClient.cs |
Refactored request interception logic |
loc/**/*.lcl |
Extensive localization updates across multiple languages |
| @@ -1 +1,2 @@ | |||
| #nullable enable | |||
| Microsoft.AspNetCore.Components.WebView.Maui.BlazorWebView.WebResourceRequested -> System.EventHandler<Microsoft.Maui.Controls.WebViewWebResourceRequestedEventArgs!>? | |||
There was a problem hiding this comment.
This appears to be a new public API member being added. Please verify this is not a breaking change, as breaking changes should not be made in minor versions or service releases.
| /// Defines a contract for a view that renders Blazor content. | ||
| /// </summary> | ||
| public interface IBlazorWebView : IView | ||
| public interface IBlazorWebView : IView, IWebRequestInterceptingWebView |
There was a problem hiding this comment.
This is a breaking change to the public interface signature. Adding a new base interface to an existing public interface is a breaking change that should not be made in minor versions or service releases.
|
/rebase |
github-actions
bot
force-pushed
the
scroll-view-refactor
branch
from
383e3d4 to
9dcffd2
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
scroll-view-refactor
branch
from
9dcffd2 to
676becb
Compare
4 participants
Description of Change
Refactored the
CrossPlatformMeasuremethod for ScrollViewHandler on Android and Windows, so that it is similar to the iOS one introduced by this PR #26763@PureWeen