BindableLayout should disconnect handlers #27450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey there @albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
added
the
perf/memory-leak 💦
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
github-actions
bot
force-pushed
the
bindable-layout-disconnect-handler
branch
from
1508ee3 to
7542ea7
Compare
Contributor
|
/rebase |
github-actions
bot
force-pushed
the
bindable-layout-disconnect-handler
branch
from
7542ea7 to
2628799
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
approved these changes
Feb 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
.NET MAUI 9 introduced automatic handler disconnection, but
BindableLayoutwas not changed to implement such behavior.This PR makes it happen and also fixes a regression from #23136 where
BindableLayoutis not invoking theMapClearhandler and instead invokingMapRemovefor each child.Issues Fixed