Skip to content

Conversation

@kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Mar 3, 2025

Issues Fixed

Fixes #7045
Fixes #21466

Before After iOS
Screen.Recording.2025-03-03.at.13.36.26.mov
Screen.Recording.2025-03-03.at.13.34.40.mov
Screen.Recording.2025-03-03.at.13.33.40.mov

@kubaflo kubaflo requested a review from a team as a code owner March 3, 2025 12:39
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Mar 3, 2025
@dotnet-policy-service
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo added platform/android area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution and removed community ✨ Community Contribution labels Mar 3, 2025
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

App.WaitForElement("NavigateButton");
App.Click("NavigateButton");
App.WaitForElement("DetailPageLabel");
VerifyScreenshot();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshots. Already available in the latest build.

Example, Windows:
image

Could you commit the images?

@kubaflo kubaflo force-pushed the Shell-BackButtonBehavior-binding-Command-to-valid-ICommand-causes-back-button-to-disappear branch from 38f3b2c to 08dad23 Compare March 4, 2025 13:56
@jsuarezruiz
Copy link
Contributor

/rebase

@github-actions github-actions bot force-pushed the Shell-BackButtonBehavior-binding-Command-to-valid-ICommand-causes-back-button-to-disappear branch from 08dad23 to ec99ee7 Compare March 28, 2025 09:40
@kubaflo kubaflo force-pushed the Shell-BackButtonBehavior-binding-Command-to-valid-ICommand-causes-back-button-to-disappear branch from ec99ee7 to 25e321d Compare March 29, 2025 00:13
@kubaflo kubaflo self-assigned this Mar 29, 2025
@sheiksyedm
Copy link
Contributor

@kubaflo This PR has fixed issue #21466. Please link the issue to this PR.

@jfversluis
Copy link
Member

/rebase

@github-actions github-actions bot force-pushed the Shell-BackButtonBehavior-binding-Command-to-valid-ICommand-causes-back-button-to-disappear branch from 25e321d to f76ba9c Compare August 29, 2025 12:11
Copilot AI review requested due to automatic review settings August 29, 2025 12:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jfversluis
Copy link
Member

/azp run MAUI-UITests-public

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kubaflo kubaflo force-pushed the Shell-BackButtonBehavior-binding-Command-to-valid-ICommand-causes-back-button-to-disappear branch from f76ba9c to e8d7c46 Compare September 2, 2025 22:26
@StephaneDelcroix
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen changed the base branch from main to inflight/candidate September 18, 2025 20:15
@PureWeen PureWeen merged commit 569839f into dotnet:inflight/candidate Sep 18, 2025
129 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 18, 2025
…causes back button to disappear (#28132)

* [Android] Shell.BackButtonBehavior - improvement

* Added a UITest

* Updated snapshots
github-actions bot pushed a commit that referenced this pull request Sep 23, 2025
…causes back button to disappear (#28132)

* [Android] Shell.BackButtonBehavior - improvement

* Added a UITest

* Updated snapshots
github-actions bot pushed a commit that referenced this pull request Sep 23, 2025
…causes back button to disappear (#28132)

* [Android] Shell.BackButtonBehavior - improvement

* Added a UITest

* Updated snapshots
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution platform/android

Projects

None yet

7 participants