Skip to content

Shell - Propagate BackButtonBehaviorProperty #28615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2025
Merged

Shell - Propagate BackButtonBehaviorProperty #28615

merged 2 commits into from
Sep 19, 2025
+82 −0

Conversation

@kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Mar 25, 2025

Issues Fixed

Fixes #28570

@kubaflo kubaflo requested a review from a team as a code owner March 25, 2025 23:46
@kubaflo kubaflo requested review from rmarinho and tj-devel709 March 25, 2025 23:46
@kubaflo kubaflo self-assigned this Mar 25, 2025
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Mar 25, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Mar 25, 2025

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo mentioned this pull request Mar 25, 2025
Open
jsuarezruiz
jsuarezruiz reviewed Mar 26, 2025
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could include a test?

@kubaflo
Copy link
Contributor Author

kubaflo commented Mar 26, 2025

Could include a test?

Done

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Mar 26, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 26, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho added this to the .NET 9 SR7 milestone Apr 11, 2025
@PureWeen PureWeen modified the milestones: .NET 9 SR7, .NET 9 SR8 May 8, 2025
@PureWeen PureWeen modified the milestones: .NET 9 SR8, .NET 9 SR9 Jun 9, 2025
@PureWeen PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Jun 9, 2025
@PureWeen PureWeen modified the milestones: .NET 9 SR9, .NET 9 SR10 Jul 3, 2025
@PureWeen PureWeen modified the milestones: .NET 9 SR10, .NET 9 SR12 Aug 4, 2025
@PureWeen
Copy link
Member

PureWeen commented Aug 20, 2025

/rebase

@github-actions github-actions bot force-pushed the shell-backbuttonbehavior-property-propagation branch from 19a17ef to 8d79637 Compare August 20, 2025 19:30
Copilot AI review requested due to automatic review settings August 20, 2025 19:30
Copilot AI reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@PureWeen
Copy link
Member

PureWeen commented Aug 20, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 20, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen modified the milestones: .NET 9 SR12, .NET 10 SR1 Sep 10, 2025
PureWeen
PureWeen requested changes Sep 11, 2025
View reviewed changes
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rebase this to net10?
#28615

@github-project-automation github-project-automation bot moved this from Ready To Review to Changes Requested in MAUI SDK Ongoing Sep 11, 2025
@kubaflo kubaflo force-pushed the shell-backbuttonbehavior-property-propagation branch from 8d79637 to bb761c3 Compare September 11, 2025 15:14
@kubaflo kubaflo changed the base branch from main to net10.0 September 11, 2025 15:14
@PureWeen
Copy link
Member

PureWeen commented Sep 11, 2025

/azp run

@github-project-automation github-project-automation bot moved this from Changes Requested to Approved in MAUI SDK Ongoing Sep 11, 2025
@azure-pipelines
Copy link

azure-pipelines bot commented Sep 11, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho merged commit 86c038a into dotnet:net10.0 Sep 19, 2025
148 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Sep 19, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@rmarinho rmarinho rmarinho approved these changes

@PureWeen PureWeen PureWeen approved these changes

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 was automatically assigned from dotnet/dotnet-maui-reviewers

+2 more reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz left review comments

@bhavanesh2001 bhavanesh2001 bhavanesh2001 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kubaflo kubaflo

Labels

area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution partner/syncfusion/review platform/android platform/ios platform/windows

Projects

MAUI SDK Ongoing
Status: Done

Milestone

.NET 10.0 SR1

Development

Successfully merging this pull request may close these issues.

Setting BackButtonBehavior to not visible or not enabled does not work

5 participants

@kubaflo @jsuarezruiz @PureWeen @rmarinho @bhavanesh2001