Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
58 changes: 58 additions & 0 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue17204.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
namespace Maui.Controls.Sample.Issues;

[Issue(IssueTracker.Github, 17204, "SwipeView does not work correctly on iOS when opened programmatically", PlatformAffected.iOS)]
public class Issue17204 : ContentPage
{
public Issue17204()
{
var verticalStack = new VerticalStackLayout
{
Spacing = 20,
Padding = new Thickness(20)
};

var swipeView = new SwipeView
{
Background = Colors.LightPink,
};

var label = new Label
{
HeightRequest = 200,
VerticalTextAlignment = TextAlignment.Center,
Text = "Programmatic swipe works"
};

var swipeItemView = new SwipeItemView
{
Background = Colors.LightGreen,
Content = label,
};

var swipeItems = new SwipeItems();
swipeItems.Add(swipeItemView);
swipeView.RightItems = swipeItems;

swipeView.Content = new Label
{
HeightRequest = 200,
VerticalTextAlignment = TextAlignment.Center,
Text = "Swipe view"
};

var button = new Button
{
Text = "Open SwipeView",
AutomationId = "OpenSwipeViewButton"
};

button.Clicked += (sender, e) =>
{
swipeView.Open(OpenSwipeItem.RightItems, false);
};

verticalStack.Add(swipeView);
verticalStack.Add(button);
Content = verticalStack;
}
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#if TEST_FAILS_ON_WINDOWS // Cannot open programatically a SwipeView on Windows.
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;
namespace Microsoft.Maui.TestCases.Tests.Issues;

public class Issue17204 : _IssuesUITest
{
public override string Issue => "SwipeView does not work correctly on iOS when opened programmatically";

public Issue17204(TestDevice device)
: base(device)
{ }

[Test]
[Category(UITestCategories.SwipeView)]
public void ProgrammaticallyOpenedSwipeViewShouldBeVisible()
{
App.WaitForElement("OpenSwipeViewButton");
App.Tap("OpenSwipeViewButton");
VerifyScreenshot();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshot on Mac and Windows. Running a build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuarezruiz, I have updated the snapshot on macOS. On Windows, we have restricted the test because programmatically opening the SwipeView does not work.

}
}
#endif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 7 additions & 1 deletion src/Core/src/Platform/iOS/MauiSwipeView.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1144,11 +1144,17 @@ internal void ProgrammaticallyOpenSwipeItem(OpenSwipeItem openSwipeItem, bool an
return;

UpdateIsOpen(true);
UpdateSwipeItems();

var swipeThreshold = GetSwipeThreshold();
UpdateOffset(swipeThreshold);

UpdateSwipeItems();
// Set the background on the swipe view, we need to update the layout.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand the comment with more details?

if (_contentView is WrapperView)
{
LayoutIfNeeded();
}

Swipe(animated);

_swipeOffset = Math.Abs(_swipeOffset);
Expand Down
Loading