Skip to content

[Testing] Fix ADB Key Generation Failure on CI #30092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2025
Merged

[Testing] Fix ADB Key Generation Failure on CI #30092

merged 2 commits into from
Jun 24, 2025

Conversation

@jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Jun 20, 2025

Description of Change

This PR addresses the issue where Android ADB key files (adbkey and adbkey.pub) may fail to be created sometimes.

Changes:

  • Multiple Key Generation Methods Added: Supports several ADB key generation strategies (e.g. native ADB tooling, fallback logic). Each method is isolated and evaluated independently.
  • Robust Error Handling: Each generation attempt includes structured error catching and reporting, reducing the risk of silent failures.
  • Comprehensive Logging: Adds detailed diagnostic output for each step to aid troubleshooting and improve observability in CI.

@jsuarezruiz jsuarezruiz marked this pull request as ready for review June 24, 2025 14:19
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner June 24, 2025 14:19
@PureWeen PureWeen merged commit 6262d96 into main Jun 24, 2025
129 checks passed
@PureWeen PureWeen deleted the fix-droid-keys-linux branch June 24, 2025 17:14
NanthiniMahalingam pushed a commit to NanthiniMahalingam/maui that referenced this pull request Jun 27, 2025
@jsuarezruiz @NanthiniMahalingam
[Testing] Fix ADB Key Generation Failure on CI (dotnet#30092)
b8be5f5 
* Adding different options to generate adb keys

* More changes
@renovate renovate bot mentioned this pull request Jul 15, 2025
Closed
1 task
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rmarinho rmarinho rmarinho approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix was automatically assigned from dotnet/dotnet-maui-reviewers

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis was automatically assigned from dotnet/dotnet-maui-reviewers

Assignees

No one assigned

Labels

area-testing Unit tests, device tests platform/android t/housekeeping ♻︎

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jsuarezruiz @rmarinho @PureWeen