Fix Changing Location on a Pin does nothing #30201
Conversation
|
Hey there @@NirmalKumarYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
There was a problem hiding this comment.
Could you include the sample from the issue in the Gallery? https://github.com/dotnet/maui/tree/main/src/Controls/samples/Controls.Sample/Pages/Controls/MapsGalleries
@jsuarezruiz , i have modified the gallery and introduced a move pin button to update the pin. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| _randomLocations[_locationRandomSeed.Next(_randomLocations.Length)]; | ||
|
|
||
| void MoveMapTo(Position location) => | ||
| pinsMap.MoveToRegion(MapSpan.FromCenterAndRadius(location, Distance.FromKilometers(5))); |
There was a problem hiding this comment.
Could be nice to create a constant:
const double DefaultMapRadiusKm = 5.0;
| // to avoid potential memory leaks (the Marker is owned by the Google Maps view) | ||
| WeakReference<Marker>? _markerWeakReference; | ||
|
|
||
| internal Marker? Marker |
There was a problem hiding this comment.
Add a DisconnectHandler override to properly clean up the weak reference when the handler is disconnected.
There was a problem hiding this comment.
@jsuarezruiz , Added DisconnectHandler. Please let me know if you have any concerns.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue details
Changing the Location property on a Microsoft.Maui.Controls.Maps.Pin does not change the location of the Pin on the map.
Root cause
MapPinHandler.Android.cswas only updating theMarkerOptionsobject when the Location property changedThe actual
Markerobject already added to the map was not being updated, causing the pin to stay in its original locationDescription of change
AddPinsmethod inMapHandlerto store marker references in theMapPinHandlerfor future property updates, ensuring tighter integration between pins and markers.Validated the behaviour in the following platforms
Issues Fixed
Fixes #12916
Output
Before.mov
After.mov