Skip to content

Conversation

@rmarinho
Copy link
Member

@rmarinho rmarinho commented Jul 8, 2025

Description of Change

Use darc to update the arcade bits |

 darc update-dependencies --channel ".NET 9 Eng" --verbose

This pull request updates several dependencies and configurations across multiple files to ensure compatibility with newer versions and improve project setup. The most important changes involve upgrading dependencies, modifying configuration files, and adding conditional logic for PME service connections.

Dependency Updates:

  • Updated multiple dependencies in eng/Version.Details.xml to version 9.0.0-beta.25325.4, including Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Installers, and others. Corresponding SHA values were updated as well.
  • Updated package versions in eng/Versions.props to align with the new dependency versions, such as MicrosoftDotNetBuildTasksFeedVersion and MicrosoftDotNetRemoteExecutorPackageVersion.
  • Updated the dotnet tool version to 9.0.107 and upgraded related SDK versions in global.json.

Configuration Changes:

  • Added conditional logic in eng/common/core-templates/job/job.yml to set ConnectedPMEServiceName based on the System.TeamProject variable. This ensures proper service connection configuration for different projects.
  • Introduced a <packageSourceMapping> section in eng/common/internal/NuGet.config with a <clear /> directive, preparing the configuration for future package source mappings.

Copilot AI review requested due to automatic review settings July 8, 2025 17:33
@rmarinho rmarinho requested a review from a team as a code owner July 8, 2025 17:33
@rmarinho rmarinho requested review from jfversluis and mattleibow July 8, 2025 17:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades .NET 9 Arcade tool and SDK versions across build configurations, adds package source mapping scaffolding, and injects conditional PME service connection settings in the job template.

  • Bumped dotnet and Arcade/Helix SDK versions in global.json, eng/Versions.props, and eng/Version.Details.xml
  • Introduced an empty <packageSourceMapping> section in eng/common/internal/NuGet.config
  • Added Azure Pipelines conditional logic for ConnectedPMEServiceName in eng/common/core-templates/job/job.yml

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
global.json Updated dotnet tool and Arcade/Helix SDK prerelease versions
eng/common/internal/NuGet.config Added <packageSourceMapping> with a <clear /> directive
eng/common/core-templates/job/job.yml Added conditional ConnectedPMEServiceName based on project
eng/Versions.props Bumped dependency version props to 9.0.0-beta.25325.4
eng/Version.Details.xml Updated toolset dependency versions and SHAs
Comments suppressed due to low confidence (1)

eng/common/core-templates/job/job.yml:137

  • Azure Pipelines template expressions (${{ }}) run at compile time and cannot evaluate runtime variables. To branch on System.TeamProject, use a runtime expression (e.g., $[ eq(variables['System.TeamProject'], 'DevDiv') ]) or refactor into a template parameter.
          ${{ if eq(variables['System.TeamProject'], 'DevDiv') }}:

<add key="dotnet-core-internal-tooling" value="https://pkgs.dev.azure.com/devdiv/_packaging/dotnet-core-internal-tooling/nuget/v3/index.json" />
</packageSources>
<packageSourceMapping>
<clear />
Copy link

Copilot AI Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introducing an empty with only will remove all default mappings and could prevent package resolution. Consider defining the necessary elements or delaying the insertion until mappings are ready.

Suggested change
<clear />
<clear />
<package pattern="dotnet-core-internal-tooling/*" source="dotnet-core-internal-tooling" />

Copilot uses AI. Check for mistakes.
@rmarinho rmarinho merged commit d145ee8 into main Jul 9, 2025
123 of 129 checks passed
@rmarinho rmarinho deleted the update-arcade-net9 branch July 9, 2025 15:53
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants