Skip to content

Conversation

@SuthiYuvaraj
Copy link
Contributor

@SuthiYuvaraj SuthiYuvaraj commented Aug 19, 2025

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

This PR updates the PageDetail property in FlyoutPage.cs.
The change simplifies the navigation logic by:

  • Removing the NavigationPage unwrapping.
  • Replacing the explicit null-check with the null-conditional operator.
    With this update, SendNavigatingFrom is invoked directly on the current value.

Related PR
PR Link #28384

Issues Fixed

Fixes #30985

Tested the existing UI and DeviceTest in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

@dotnet-policy-service dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Aug 19, 2025
@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@SuthiYuvaraj SuthiYuvaraj marked this pull request as ready for review August 21, 2025 05:06
Copilot AI review requested due to automatic review settings August 21, 2025 05:06
@SuthiYuvaraj SuthiYuvaraj requested a review from a team as a code owner August 21, 2025 05:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the navigation event handling logic in FlyoutPage by removing NavigationPage unwrapping and streamlining the code. The change ensures that navigation events (SendNavigatingFrom, SendNavigatedFrom, and SendNavigatedTo) are called directly on the actual Page objects rather than attempting to unwrap NavigationPages to get their current pages.

Key changes:

  • Removes complex NavigationPage unwrapping logic that was extracting CurrentPage from NavigationPages
  • Simplifies null checking using the null-conditional operator
  • Updates navigation event arguments to pass the actual Page objects directly

Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuthiYuvaraj can you add some unit tests for this change?

There should be a pretty large set of unit tests (not UI tests) already testing this feature

@PureWeen PureWeen added this to the .NET 10.0-rc2 milestone Aug 22, 2025
@PureWeen PureWeen added p/0 Current heighest priority issues that we are targeting for a release. p/2 Work that is important, but is currently not scheduled for release and removed p/2 Work that is important, but is currently not scheduled for release labels Aug 23, 2025
jsuarezruiz
jsuarezruiz previously approved these changes Aug 26, 2025
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Sep 3, 2025
@jsuarezruiz
Copy link
Contributor

/rebase

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@github-project-automation github-project-automation bot moved this from Ready To Review to Approved in MAUI SDK Ongoing Sep 11, 2025
@PureWeen
Copy link
Member

@SuthiYuvaraj it looks like the test failure might be real?
PullToRefreshWorksWhenEnabled

Or we need to rebase this?

@SuthiYuvaraj
Copy link
Contributor Author

@PureWeen, This failure is due to a flaky test case (PullToRefreshWorksWhenEnabled) and is not related to my changes. We can try rerunning the CI.

@PureWeen
Copy link
Member

/rebase

@PureWeen
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen merged commit de63a9d into dotnet:net10.0 Sep 16, 2025
146 of 148 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Sep 16, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community ✨ Community Contribution p/0 Current heighest priority issues that we are targeting for a release. partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants