Fix file locking race condition in parallel builds by adding retry logic to Copy tasks #31364
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses file locking race conditions that occur during parallel builds when multiple projects simultaneously copy files to the shared $(_MauiBuildTasksLocation) directory. The fix adds retry logic to all Copy tasks targeting this shared location.
- Adds retry logic with 3 attempts and 1-second delays to prevent build failures from transient file locks
- Standardizes retry behavior across all projects that copy to the shared build tasks directory
- Maintains build performance while improving reliability in parallel build scenarios
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/SingleProject/Resizetizer/src/Resizetizer.csproj | Added retry logic to two Copy tasks for resizetizer files and Svg.Skia.dll |
| src/Core/src/Core.csproj | Added retry logic to Copy task for core framework files |
| src/Controls/src/SourceGen/Controls.SourceGen.csproj | Added retry logic to Copy task for source generator assemblies |
| src/Controls/src/Build.Tasks/Controls.Build.Tasks.csproj | Added retry logic to Copy task for build task assemblies |
| src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj | Added retry logic to Copy task for binding source generator assemblies |
jfversluis
approved these changes
Sep 2, 2025
jfversluis
added
the
area-infrastructure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Multiple projects have _CopyToBuildTasksDir targets that copy files to the same $(_MauiBuildTasksLocation) directory during build. When builds run in parallel, these Copy tasks create a race condition where one process might be writing a file while another process tries to read it.
In this PR, added retry logic with delays to all Copy tasks that write to the shared build tasks directory. Changed
Retries="0"toRetries="3" RetryDelayMilliseconds="1000"to allow up to 3 retry attempts with 1-second delays between attempts. This provides more resilience against transient file locking during parallel builds but maintaining build performance.Issues Fixed
Fixes #24615