[iOS, Mac] TabbedPage overflow "More" button does not works #31385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the TabbedPage implementation on iOS and Mac where the "More" button navigation was not working correctly. The issue occurred when iOS automatically creates a "More" navigation controller for TabbedPages with more than 5 tabs.
- Prevents UpdateCurrentPage from being called when the "More" navigation controller is selected
- Adds a guard clause to handle the special case of "More" tab navigation
- Resolves the navigation issue that prevented users from accessing additional tabs through the "More" button
Member
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jfversluis
approved these changes
Sep 2, 2025
Prevents UpdateCurrentPage from being called when the 'More' navigation controller is selected in TabbedRenderer on iOS, handling the special case where the user navigates to additional tabs.
jfversluis
force-pushed
the
fix-31377
branch
from
c4436e4 to
a18af64
Compare
PureWeen
pushed a commit
that referenced
this pull request
Sep 8, 2025
Prevents UpdateCurrentPage from being called when the 'More' navigation controller is selected in TabbedRenderer on iOS, handling the special case where the user navigates to additional tabs. Added a UITest
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Prevents UpdateCurrentPage from being called when the 'More' navigation controller is selected in TabbedRenderer on iOS, handling the special case where the user navigates to additional tabs.
Issues Fixed
Screen.Recording.2025-08-29.at.01.13.36.mov
Screen.Recording.2025-08-29.at.01.11.25.mov
Fixes #31377