[Windows] Optimize Label.CharacterSpacing on initial load
#31391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey there @@MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
added
area-controls-label
jsuarezruiz
reviewed
Aug 29, 2025
| public static void MapCharacterSpacing(ILabelHandler handler, ILabel label) => | ||
| public static void MapCharacterSpacing(ILabelHandler handler, ILabel label) | ||
| { | ||
| if (handler.IsConnectingHandler() && label.CharacterSpacing == 0) |
Contributor
There was a problem hiding this comment.
LGTM, avoids setting the default CharacterSpacing value during the initial setup of the control or when is not necessary, which should give a performance boost in scenarios with many labels.
Running a build to verify if not have any impact in some test scenario related with Label.CharacterSpacing.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
Author
|
@jsuarezruiz It looks like the tests passed. |
jsuarezruiz
approved these changes
Sep 1, 2025
MartyIX
deleted the
feature/2025-08-29-Windows-perf-character-spacing
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Performance improvement
main- maui.sandbox.2025-08-29_08-49-20.main.speedscope.jsonSo this PR should translate to saving about 15 ms in my grid scenario (#21787). I'm not sure why it is so costly but it's like that:
Issues Fixed
Contributes to #21787