[Windows] Optimize TextHighlighters use
#31429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
MartyIX
added
the
perf/general
Contributor
Author
|
It looks like the tests passed. The failing tests are related to Android. |
MartyIX
commented
Sep 8, 2025
| else | ||
| { | ||
| if (platformControl.TextHighlighters.Count > 0) | ||
| if (!label.IsConnectingHandler() && platformControl.TextHighlighters.Count > 0) |
Contributor
Author
There was a problem hiding this comment.
This is the main change.
jfversluis
approved these changes
Sep 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Performance improvement
main- maui.sandbox.2025-09-01_10-27-21.main.speedscope.jsonIssues Fixed
Contributes to #21787