-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Essentials] Add microphone permission handling on Windows and tests #31451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| using System.Threading.Tasks; | ||
| using Microsoft.Maui.ApplicationModel; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.Maui.Essentials.DeviceTests; | ||
|
|
||
| [Category("Permissions")] | ||
| public class Microphone_Tests | ||
| { | ||
| [Fact] | ||
| [Trait(Traits.InteractionType, Traits.InteractionTypes.Human)] | ||
| public async Task Request_Microphone_Denied_Returns_Denied() | ||
| { | ||
| // If microphone permission was previously granted, the OS won't show a new prompt. | ||
| // In that case we can't exercise the prompt flow, so skip the test. | ||
| var initial = await Permissions.CheckStatusAsync<Permissions.Microphone>(); | ||
| if (initial == PermissionStatus.Granted) | ||
| return; // nothing to prompt; skip | ||
|
|
||
| // This test requires human interaction: When prompted, choose Deny for microphone access | ||
| var status = await MainThread.InvokeOnMainThreadAsync(Permissions.RequestAsync<Permissions.Microphone>); | ||
| Assert.Equal(PermissionStatus.Denied, status); | ||
|
|
||
| // And subsequent checks should reflect Denied | ||
| var check = await Permissions.CheckStatusAsync<Permissions.Microphone>(); | ||
| Assert.Equal(PermissionStatus.Denied, check); | ||
| } | ||
|
|
||
| [Fact] | ||
| [Trait(Traits.InteractionType, Traits.InteractionTypes.Human)] | ||
| public async Task Request_Microphone_Allowed_Returns_Granted() | ||
morning4coffe-dev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| { | ||
| // If microphone permission was previously granted, the OS won't show a new prompt. | ||
| // In that case we can't exercise the prompt flow, so skip the test. | ||
| var initial = await Permissions.CheckStatusAsync<Permissions.Microphone>(); | ||
| if (initial == PermissionStatus.Granted) | ||
| return; // nothing to prompt; skip | ||
|
|
||
| // This test requires human interaction: When prompted, choose Allow for microphone access | ||
| var status = await MainThread.InvokeOnMainThreadAsync(Permissions.RequestAsync<Permissions.Microphone>); | ||
| Assert.Equal(PermissionStatus.Granted, status); | ||
|
|
||
| // And subsequent checks should reflect Granted | ||
| var check = await Permissions.CheckStatusAsync<Permissions.Microphone>(); | ||
| Assert.Equal(PermissionStatus.Granted, check); | ||
| } | ||
|
|
||
| [Fact] | ||
| [Trait(Traits.InteractionType, Traits.InteractionTypes.Human)] | ||
| public async Task Request_Microphone_Granted_Then_RequestAgain_Returns_Granted() | ||
| { | ||
| // Ensure we have the Granted state first (may require human interaction on first request) | ||
| var status = await Permissions.CheckStatusAsync<Permissions.Microphone>(); | ||
| if (status != PermissionStatus.Granted) | ||
| { | ||
| // Human: choose Allow when prompted | ||
| status = await MainThread.InvokeOnMainThreadAsync(Permissions.RequestAsync<Permissions.Microphone>); | ||
| if (status != PermissionStatus.Granted) | ||
| return; // Can't proceed with this test if user denied; treat as skip | ||
| } | ||
|
|
||
| // Second request should short-circuit and still return Granted without a new prompt | ||
| var second = await MainThread.InvokeOnMainThreadAsync(Permissions.RequestAsync<Permissions.Microphone>); | ||
| Assert.Equal(PermissionStatus.Granted, second); | ||
|
|
||
| // Status check remains Granted | ||
| var check = await Permissions.CheckStatusAsync<Permissions.Microphone>(); | ||
| Assert.Equal(PermissionStatus.Granted, check); | ||
| } | ||
|
|
||
| [Fact] | ||
| [Trait(Traits.InteractionType, Traits.InteractionTypes.Human)] | ||
| public async Task Request_Microphone_Denied_Then_RequestAgain_Returns_Denied() | ||
| { | ||
| // If already granted we can't meaningfully test denied flow again without application/OS settings reset | ||
| var initial = await Permissions.CheckStatusAsync<Permissions.Microphone>(); | ||
| if (initial == PermissionStatus.Granted) | ||
| return; // skip | ||
|
|
||
| // First request: Human choose Deny when prompted (if prompt appears) | ||
| var first = await MainThread.InvokeOnMainThreadAsync(Permissions.RequestAsync<Permissions.Microphone>); | ||
| if (first != PermissionStatus.Denied) | ||
| return; // can't assert repeat deny path if user allowed or unknown | ||
|
|
||
| // Second request should return Denied again (idempotent) and not elevate permission | ||
| var second = await MainThread.InvokeOnMainThreadAsync(Permissions.RequestAsync<Permissions.Microphone>); | ||
| Assert.Equal(PermissionStatus.Denied, second); | ||
|
|
||
| var check = await Permissions.CheckStatusAsync<Permissions.Microphone>(); | ||
| Assert.Equal(PermissionStatus.Denied, check); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.