Skip to content

[Windows] Allow to remove shadows at runtime #31452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2025
Merged

[Windows] Allow to remove shadows at runtime #31452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cde8526
WIP
MartyIX Sep 2, 2025
326ee2b
Update snapshot
MartyIX Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/Issue24414Test_5.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 10 additions & 3 deletions src/Core/src/Platform/Windows/WrapperView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,13 +167,20 @@ void UpdateBorder()

partial void ShadowChanged()
{
if (HasShadow)
if (Shadow?.Paint is { })
Copy link
Contributor Author

@MartyIX MartyIX Sep 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: You can compare the new snapshot in this PR with the Android one: https://github.com/dotnet/maui/blob/main/src/Controls/tests/TestCases.Android.Tests/snapshots/android/Issue24414Test_5.png. There should be no shadow visible in Issue24414Test_5.png snapshots.

{
UpdateShadowAsync().FireAndForget(IPlatformApplication.Current?.Services?.CreateLogger(nameof(WrapperView)));
if (HasShadow)
{
UpdateShadowAsync().FireAndForget(IPlatformApplication.Current?.Services?.CreateLogger(nameof(WrapperView)));
}
else
{
CreateShadowAsync().FireAndForget(IPlatformApplication.Current?.Services?.CreateLogger(nameof(WrapperView)));
}
}
else
{
CreateShadowAsync().FireAndForget(IPlatformApplication.Current?.Services?.CreateLogger(nameof(WrapperView)));
DisposeShadow();
}
}

Expand Down