Skip to content

Fix DisplayAlert to properly pass the cancel parameter to DisplayAlertAsync #31474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

Fix DisplayAlert to properly pass the cancel parameter to DisplayAlertAsync #31474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Controls/src/Core/Page/Page.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ public Task DisplayAlert(string title, string message, string cancel, FlowDirect
/// <inheritdoc cref="DisplayAlertAsync(string, string, string, string, FlowDirection)"/>
[Obsolete("Use DisplayAlertAsync instead")]
Copy link
Contributor

@jsuarezruiz jsuarezruiz Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick note, This is an [Obsolete] method marked for removal. Users are explicitly directed to use DisplayAlertAsync instead, so, the change fixes a bug in code that should ideally not be used.

Copy link
Contributor Author

@thisisthekap thisisthekap Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aware that this method is marked for removal. But as it is used (e.g. by https://github.com/PrismLibrary/Prism), we need to make sure that the method works properly.

public Task<bool> DisplayAlert(string title, string message, string accept, string cancel, FlowDirection flowDirection)
=> DisplayAlertAsync(title, message, accept, null, flowDirection);
=> DisplayAlertAsync(title, message, accept, cancel, flowDirection);

/// <inheritdoc cref="DisplayAlertAsync(string, string, string, string, FlowDirection)"/>
public Task DisplayAlertAsync(string title, string message, string cancel)
Expand Down
Loading