Skip to content

Conversation

@TamilarasanSF4853
Copy link
Contributor

@TamilarasanSF4853 TamilarasanSF4853 commented Nov 20, 2025

This PR addresses test failures in the main and inflight/candidate branches and includes updates to improve rendering and test stability across platforms.

  • The DoesNotCrash test for Bugzilla39636 was failing and throwing an exception after the HostApp project switched to the XAML Source Generator inflator in PR [XSG] Enable XSG on HostApp #32039. The failure occurred because the <OnPlatform> resource did not specify a value for MacCatalyst, which is now required by the SourceGen XAML compiler.
  • This PR adds an explicit <On Platform="MacCatalyst" Value="50"/> resource in Bugzilla39636.xaml, resolving the test failure.

Fixes #32772

Tests case:

  • DoesNotCrash

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Nov 20, 2025
@dotnet-policy-service
Copy link
Contributor

Hey there @@TamilarasanSF4853! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Nov 20, 2025
@sheiksyedm sheiksyedm marked this pull request as ready for review November 20, 2025 14:20
Copilot AI review requested due to automatic review settings November 20, 2025 14:20
@sheiksyedm sheiksyedm added the area-testing Unit tests, device tests label Nov 20, 2025
Copilot finished reviewing on behalf of sheiksyedm November 20, 2025 14:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a test failure in the Bugzilla39636 test case that occurred after the HostApp project switched to the XAML Source Generator inflator. The failure was caused by missing MacCatalyst platform-specific values in OnPlatform resources, which are now required by the SourceGen XAML compiler.

  • Added explicit MacCatalyst platform values to two OnPlatform resource definitions
  • The chosen value (50) is consistent and falls between iOS (40) and UWP (60) values

@sheiksyedm
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@StephaneDelcroix StephaneDelcroix merged commit b62ccc8 into dotnet:main Nov 20, 2025
158 of 169 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Mac] A TargetInvocationException occurred when enabling SourceGen.

3 participants