Implement IsTextPredictionEnabled in IEntry Handlers

[almirvuk]

Implements #381

• Adds bool IsTextPredictionEnabled { get; } to the IEntry interface
• Adds IsTextPredictionEnabled property map to EntryHandler
• Adds IsTextPredictionEnabled mapping methods to EntryHandler for Android and iOS
• Adds extension methods to apply IsTextPredictionEnabled on Android/iOS
• Adds DeviceTests for initial IsTextPredictionEnabled values on iOS and Android

[hartez]

Looks good. Thanks!

[rmarinho]

/azp run

[mattleibow]

Thanks for the PR. Looking good and I just have 2 thoughts.

Not for this PR, but a note for future me and other peoples. We need to create a helper method to test changes. Like init to X, test, set to Y, and confirm it changes. And then do the reverse order.

This is very useful to determine if the "undo" operation works. Like set IsPassword to false, test, true, test and then false again, test.

[mattleibow]

I am thinking this is unnecessary setting of the native property. Even though it is fast and, maybe we can use a variable and pipe them all. Then at the end, we set it?

[bkaankose]

This enhancement is addressed in #507.

[mattleibow]

Marking this red just in case I am right and we can't unset the value.

[almirvuk]

@mattleibow can you please take a look now? :)

[mattleibow]

@almirvuk could you add this test just so we don't ever break this feature in the future:

		[Theory(DisplayName = "IsTextPredictionEnabled Updates Correctly")]
		[InlineData(true, true)]
		[InlineData(true, false)]
		[InlineData(false, true)]
		[InlineData(false, false)]
		public async Task IsTextPredictionEnabledUpdatesCorrectly(bool setValue, bool unsetValue)
		{
			var entry = new EntryStub();

			await ValidatePropertyUpdatesValue(
				entry,
				nameof(IEntry.IsTextPredictionEnabled),
				GetNativeIsTextPredictionEnabled,
				setValue,
				unsetValue);
		}

[mattleibow]

Looking great! Besides the test that I think we should add, this is good to merge!

Thanks for the PR and the work.

[almirvuk]

@almirvuk could you add this test just so we don't ever break this feature in the future:

		[Theory(DisplayName = "IsTextPredictionEnabled Updates Correctly")]
		[InlineData(true, true)]
		[InlineData(true, false)]
		[InlineData(false, true)]
		[InlineData(false, false)]
		public async Task IsTextPredictionEnabledUpdatesCorrectly(bool setValue, bool unsetValue)
		{
			var entry = new EntryStub();

			await ValidatePropertyUpdatesValue(
				entry,
				nameof(IEntry.IsTextPredictionEnabled),
				GetNativeIsTextPredictionEnabled,
				setValue,
				unsetValue);
		}

Added with the last commit :) Thank you @mattleibow

[mattleibow]

Absolutely stunning! This needs to be merged as soon as CI is green.

[mattleibow]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.