Number unexpectedly not recognized when in Swedish locale

[danmoseley]

Steps to reproduce

Build this with English (US) Windows settings. It will succeed.
Now go to Control Panel>Region>Change Date/Time/number formats>Formats tab, change to Swedish, OK. No need to reboot or reopen the command prompt.
Now build it again.

<Project>

  <PropertyGroup>
    <p>abc</p>
  </PropertyGroup>

  <Target Name="t" Condition=" $(p.IndexOf('x')) >= 0 " />
  
</Project>

Expected behavior

Success- no output - the condition is valid and evaluates to -1 >= 0

Actual behavior

C:\proj\x.proj(7,34): error MSB4086: A numeric comparison was attempted on "$(p.IndexOf('x'))" that evaluates to "-1" instead of a number, in condition " $(p.IndexOf('x')) >= 0 ".

Environment data

msbuild /version output:

C:\proj>dotnet msbuild /version
Microsoft (R) Build Engine version 16.7.0-preview-20310-07+ee1c9fd0c for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

16.7.0.31007

OS info:

Windows 10, 2004

Comments

We should parse all numbers out of strings in Invariant mode:

https://github.com/microsoft/msbuild/blob/e70a3159d64f9ed6ec3b60253ef863fa883a99b1/src/Build/Evaluation/Conditionals/NumericComparisonExpressionNode.cs#L44
https://github.com/microsoft/msbuild/blob/e70a3159d64f9ed6ec3b60253ef863fa883a99b1/src/Shared/ConversionUtilities.cs#L99

I'm not sure what's going on. Note also, that the negative sign in Sweden is apparently the regular -.

cc @maloo

[maloo]

Thanks for filing the issue. I want to note that decimal point and list separator is different in Swedish regional settings. So if you somehow use double/floats here instead of integers that could be an issue.

[danmoseley]

Having trouble reproing on another machine. Repro machine is Windows version 2004 19587.100 and msbuild16.7.0.31007, non repro is 19041.329 and 16.7.0.33088. That may not be relevant.

The key setting seems to be "Regional Format" (in the new style control panel) which corresponds to "Format" in the "Region" dialog -- the two toggle the same setting, but only lazily update to match each other.

@maloo what versions do you have of these? Does building the above project repro for you with Swedish settings?

[maloo]

@danmosemsft yes, I can repro:
Windows 1909 18363.900
MSBuild 16.7.0.31007

And running $env:DOTNET_SYSTEM_GLOBALIZATION_INVARIANT = 1 before makes the error go away.

[maloo]

I also tried MSBuild 16.6.0.22303 in dev cmd 2019, and could not repro. So looks like a regression of msbuild (or dotnet).

[maloo]

I cloned and built msbuild and version 16.8.0.36101 seems to work. Maybe just have forward this issue to dotnet/runtime and ask them to update to 16.8?

[maloo]

vs16.7 - 16.7.0.36101 also works, no repro. Is there any difference between "standalone msbuild" and msbuild bundled with dotnet?

[maloo]

I built the net472 base version, so maybe it is dotnet core related?

[danmoseley]

Unfortunately building my own copy to the same SHA doesn't give me a repro, and debugging the release version is not helpful so far.

[danmoseley]

It's not #5360 because that requires the 2-parameter overload.

[danmoseley]

I don't plan to look more, since it's apparently fixed, although it bothers me I don't see how. I will leave this issue open in case there is a test missing that builds (and evaluates conditional expressions and property functions) in a culture with different number formats.

[danmoseley]

FYI we have since discovered that when using ICU (which may be the case on some recent Windows ) the Swedish minus sign is not the typical hyphen. So the result in the bug (which may or may not be fixed now) was surely due to parsing without specifying invariant mode.

Eg dotnet/runtime#47524

[danmoseley]

@rainersigwald I suggest to close this