Skip to content

null check logging mechanism before logging glob failure #11537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanProvaznik merged 3 commits into from
Mar 5, 2025
Merged

null check logging mechanism before logging glob failure #11537

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91012cb
null check logging mechanism before logging glob failure
JanProvaznik Mar 4, 2025
9b51108
turn on nullable annotation and resolve issues
JanProvaznik Mar 5, 2025
40f7bc8
more annotations
JanProvaznik Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Build/Utilities/EngineFileUtilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ private static string[] GetFileList(
(fileList, _, _, string globFailure) = fileMatcher.GetFiles(directoryUnescaped, filespecUnescaped, excludeSpecsUnescaped);

// log globing failure with the present logging mechanism
if (globFailure != null)
if (globFailure != null && loggingMechanism != null)
{
switch (loggingMechanism)
{
Expand Down