Skip to content
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Shared/INodePacket.cs
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,9 @@
/// <returns>True if extended header flag was set, false otherwise.</returns>
public static bool TryCreateExtendedHeaderType(HandshakeOptions handshakeOptions, NodePacketType type, out byte extendedheader)
{
if (Handshake.IsHandshakeOptionEnabled(handshakeOptions, HandshakeOptions.TaskHost))
// Extended headers are supported by .NET Core+ and CLR4 task hosts, but not CLR2.
if (handshakeOptions.HasFlag(HandshakeOptions.TaskHost)
&& (handshakeOptions.HasFlag(HandshakeOptions.NET) || handshakeOptions.HasFlag(HandshakeOptions.CLR4)))

Check failure on line 334 in src/Shared/INodePacket.cs

View check run for this annotation

Azure Pipelines / msbuild-pr (Source-Build (Managed))

src/Shared/INodePacket.cs#L334

src/Shared/INodePacket.cs(334,113): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'HandshakeOptions' does not contain a definition for 'CLR4'

Check failure on line 334 in src/Shared/INodePacket.cs

View check run for this annotation

Azure Pipelines / msbuild-pr (Source-Build (Managed))

src/Shared/INodePacket.cs#L334

src/Shared/INodePacket.cs(334,113): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'HandshakeOptions' does not contain a definition for 'CLR4'

Check failure on line 334 in src/Shared/INodePacket.cs

View check run for this annotation

Azure Pipelines / msbuild-pr (macOS Core)

src/Shared/INodePacket.cs#L334

src/Shared/INodePacket.cs(334,113): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'HandshakeOptions' does not contain a definition for 'CLR4'

Check failure on line 334 in src/Shared/INodePacket.cs

View check run for this annotation

Azure Pipelines / msbuild-pr (macOS Core)

src/Shared/INodePacket.cs#L334

src/Shared/INodePacket.cs(334,113): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'HandshakeOptions' does not contain a definition for 'CLR4'

Check failure on line 334 in src/Shared/INodePacket.cs

View check run for this annotation

Azure Pipelines / msbuild-pr (macOS Core)

src/Shared/INodePacket.cs#L334

src/Shared/INodePacket.cs(334,113): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'HandshakeOptions' does not contain a definition for 'CLR4'

Check failure on line 334 in src/Shared/INodePacket.cs

View check run for this annotation

Azure Pipelines / msbuild-pr (macOS Core)

src/Shared/INodePacket.cs#L334

src/Shared/INodePacket.cs(334,113): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'HandshakeOptions' does not contain a definition for 'CLR4'

Check failure on line 334 in src/Shared/INodePacket.cs

View check run for this annotation

Azure Pipelines / msbuild-pr (macOS Core)

src/Shared/INodePacket.cs#L334

src/Shared/INodePacket.cs(334,113): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'HandshakeOptions' does not contain a definition for 'CLR4'

Check failure on line 334 in src/Shared/INodePacket.cs

View check run for this annotation

Azure Pipelines / msbuild-pr (Linux Core)

src/Shared/INodePacket.cs#L334

src/Shared/INodePacket.cs(334,113): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'HandshakeOptions' does not contain a definition for 'CLR4'

Check failure on line 334 in src/Shared/INodePacket.cs

View check run for this annotation

Azure Pipelines / msbuild-pr (Linux Core)

src/Shared/INodePacket.cs#L334

src/Shared/INodePacket.cs(334,113): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'HandshakeOptions' does not contain a definition for 'CLR4'

Check failure on line 334 in src/Shared/INodePacket.cs

View check run for this annotation

Azure Pipelines / msbuild-pr (Linux Core)

src/Shared/INodePacket.cs#L334

src/Shared/INodePacket.cs(334,113): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'HandshakeOptions' does not contain a definition for 'CLR4'

Check failure on line 334 in src/Shared/INodePacket.cs

View check run for this annotation

Azure Pipelines / msbuild-pr (Linux Core)

src/Shared/INodePacket.cs#L334

src/Shared/INodePacket.cs(334,113): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'HandshakeOptions' does not contain a definition for 'CLR4'

Check failure on line 334 in src/Shared/INodePacket.cs

View check run for this annotation

Azure Pipelines / msbuild-pr (Linux Core)

src/Shared/INodePacket.cs#L334

src/Shared/INodePacket.cs(334,113): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'HandshakeOptions' does not contain a definition for 'CLR4'

Check failure on line 334 in src/Shared/INodePacket.cs

View check run for this annotation

Azure Pipelines / msbuild-pr

src/Shared/INodePacket.cs#L334

src/Shared/INodePacket.cs(334,113): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'HandshakeOptions' does not contain a definition for 'CLR4'

Check failure on line 334 in src/Shared/INodePacket.cs

View check run for this annotation

Azure Pipelines / msbuild-pr

src/Shared/INodePacket.cs#L334

src/Shared/INodePacket.cs(334,113): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'HandshakeOptions' does not contain a definition for 'CLR4'
Comment thread
YuliiaKovalova marked this conversation as resolved.
Outdated
{
extendedheader = (byte)((byte)type | ExtendedHeaderFlag);
return true;
Expand Down
Loading