Skip to content

Final Branding For 17.0 GA #6902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ladipro merged 2 commits into from
Oct 21, 2021
Merged

Final Branding For 17.0 GA #6902

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bdfe86
Final branding for 17.0 GA
benvillalobos Oct 1, 2021
b4987c9
Move release branding to versionprefix line
benvillalobos Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<VersionPrefix>17.0.0</VersionPrefix>
<AssemblyVersion>15.1.0.0</AssemblyVersion>
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
<DotNetUseShippingVersions>true</DotNetUseShippingVersions>
<DotNetUseShippingVersions>true</DotNetUseShippingVersions><DotNetFinalVersionKind>release</DotNetFinalVersionKind>

@rainersigwald rainersigwald Oct 4, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go on the VersionPrefix line.

<!-- Workaround for https://github.com/dotnet/roslyn/issues/35793 -->
<SemanticVersioningV1>true</SemanticVersioningV1>
<MicroBuildPluginsSwixBuildVersion>1.0.672</MicroBuildPluginsSwixBuildVersion>
Expand Down