Skip to content

Enable NuGet static-graph restore#6905

Merged
ladipro merged 1 commit into
dotnet:mainfrom
rainersigwald:graph-restore
Oct 14, 2021
Merged

Enable NuGet static-graph restore#6905
ladipro merged 1 commit into
dotnet:mainfrom
rainersigwald:graph-restore

Conversation

@rainersigwald

Copy link
Copy Markdown
Member

This has been available in Arcade for a while now (dotnet/arcade#5056), and it's dogfood-y so we should have it on for our own repo.

@Forgind Forgind left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NuGet doesn't currently pass us its graph, right? So this could make restore a little more efficient but shouldn't affect build time?

@rainersigwald

Copy link
Copy Markdown
Member Author

Right, this uses static graph in the solution restore operation: instead of using MSBuild to crawl the solution, find all projects and get their references, it uses a separate executable to do so; that executable uses the static graph API to evaluate everything in parallel and extract info super fast.

CI time might come down by a few seconds but I don't think we're really over the threshold here--this is about dogfooding a feature we enable more than "we really need this".

@rainersigwald rainersigwald added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Oct 4, 2021
@ladipro ladipro merged commit 629b21a into dotnet:main Oct 14, 2021
@rainersigwald rainersigwald deleted the graph-restore branch November 22, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants