Code action to offer to wrap Html attributes#11422
Merged
davidwengier merged 2 commits intodotnet:mainfrom Feb 4, 2025
Merged
Conversation
alexgav
reviewed
Feb 4, 2025
...t/Microsoft.VisualStudio.LanguageServices.Razor.Test/Cohost/CohostCodeActionsEndpointTest.cs
Show resolved
Hide resolved
alexgav
reviewed
Feb 4, 2025
...icrosoft.CodeAnalysis.Razor.Workspaces/CodeActions/Razor/WrapAttributesCodeActionProvider.cs
Outdated
Show resolved
Hide resolved
alexgav
reviewed
Feb 4, 2025
...icrosoft.CodeAnalysis.Razor.Workspaces/CodeActions/Razor/WrapAttributesCodeActionProvider.cs
Show resolved
Hide resolved
alexgav
reviewed
Feb 4, 2025
| if (first) | ||
| { | ||
| firstAttributeLine = linePositionSpan.Start.Line; | ||
| sourceText.TryGetFirstNonWhitespaceOffset(attribute.Span, out var indentSizeOffset); |
Contributor
Member
Author
There was a problem hiding this comment.
Yes, the Razor syntax tree continues to be annoying, so (almost?) all of the attributes start with whitespace. The syntax nodes look a bit like[<][foo][ class="asdf"][/>].
alexgav
reviewed
Feb 4, 2025
| { | ||
| firstAttributeLine = linePositionSpan.Start.Line; | ||
| sourceText.TryGetFirstNonWhitespaceOffset(attribute.Span, out var indentSizeOffset); | ||
| indentSize = linePositionSpan.Start.Character + indentSizeOffset; |
Contributor
This was referenced Feb 6, 2025
Member
Author
|
FYI @leslierichardson95 for a new code action for Razor coming in a future 17.14 preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4296